many: use common.{Ki,Me,Gi}Bi instead of manually doing them
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YES :) I don't know anyone who likes to use the long form... |
Yes please! |
|
Needs a rebase and merge conflict fixing |
This commit uses `common.{Ki,Mi,Gi}B` in places that used to
write `10 * 1024 * 1024` etc. It's not really important but
feels quicker to scan when having the constants.
mvo5
force-pushed
the
use-common-mibi-gibi
branch
from
20756ca
to
481859a
Compare
Thank you! This is rebased and updated to add/use the shorthand form - fwiw, I like the shorthand a lot better as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses
common.{Ki,Me,Gi}Biin places that used to write10 * 1024 * 1024etc. It's not really important but feels quicker to scan when having the constants.Also I wonder if we should also have common.{KiB,MiB,GiB,TiB} as a shorthand?
Also just close the PR if you feel this is not worth it :)