manifest: add set -e to bootc switch... kickstart %post#2093
Merged
thozza merged 1 commit intoosbuild:mainfrom Dec 17, 2025
Merged
manifest: add set -e to bootc switch... kickstart %post#2093thozza merged 1 commit intoosbuild:mainfrom
set -e to bootc switch... kickstart %post#2093thozza merged 1 commit intoosbuild:mainfrom
Conversation
lzap
previously approved these changes
Dec 15, 2025
supakeen
previously approved these changes
Dec 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
mvo5
force-pushed
the
bootc-ks-fatal-on-error
branch
from
51b0ab1 to
939f52a
Compare
thozza
approved these changes
Dec 16, 2025
supakeen
approved these changes
Dec 16, 2025
lzap
approved these changes
Dec 16, 2025
The `bootc switch` command we use in our bootc installer ISOs stopped working [0] with the error: ``` error: Switching: Initializing storage: System not booted via bootc ``` However the install continue because while we do set `--erroronfail` the script is not setting `set -e`. This commit fixes this and makes the bootc switch error in script a hard failure. This means that installs will error currently but its better to error than to install a system that is then not connected to any updates :( [0] osbuild/image-builder-cli#410
lzap
force-pushed
the
bootc-ks-fatal-on-error
branch
from
939f52a to
5a9de35
Compare
lzap
approved these changes
Dec 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
croissanne
added a commit
to croissanne/osbuild-composer
that referenced
this pull request
Jan 21, 2026
Changes with 0.231.0 ---------------- - Drop iommu.strict=0 from aarch64 EC2 images (osbuild/images#2090) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - bootc: Fix selinux labeling when using separate build container (osbuild/images#2092) - Author: Alexander Larsson, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - ci: resolve dubious ownership for git (osbuild/images#2100) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Michael Vogt - data: import RH v4 key on rhel-10.1+ only (osbuild/images#2097) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger - distrodefs: drop `use_syslinux` as it has no effect (osbuild/images#2088) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger - fedora: /boot on btrfs for Fedora Cloud 44 (HMS-9737) (osbuild/images#1960) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Neal Gompa (ニール・ゴンパ), Tomáš Hozza - fedora: add `server-network-installer` (osbuild/images#2094) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - installer: only install `syslinux` when needed (osbuild/images#2089) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - manifest: add `set -e` to `bootc switch...` kickstart %post (osbuild/images#2093) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - many: include legal and license files in ISO (osbuild/images#2099) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - osbuild: drop `valueIn` helper (osbuild/images#2086) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger - readme: update link to image definitions (osbuild/images#2070) - Author: Anna Vítová, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - test: cross arch build/boot smoke test for ppc64le,s390x (osbuild/images#2069) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza
achilleas-k
pushed a commit
to osbuild/osbuild-composer
that referenced
this pull request
Jan 21, 2026
Changes with 0.231.0 ---------------- - Drop iommu.strict=0 from aarch64 EC2 images (osbuild/images#2090) - Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - bootc: Fix selinux labeling when using separate build container (osbuild/images#2092) - Author: Alexander Larsson, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - ci: resolve dubious ownership for git (osbuild/images#2100) - Author: Lukáš Zapletal, Reviewers: Achilleas Koutsou, Michael Vogt - data: import RH v4 key on rhel-10.1+ only (osbuild/images#2097) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger - distrodefs: drop `use_syslinux` as it has no effect (osbuild/images#2088) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger - fedora: /boot on btrfs for Fedora Cloud 44 (HMS-9737) (osbuild/images#1960) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Neal Gompa (ニール・ゴンパ), Tomáš Hozza - fedora: add `server-network-installer` (osbuild/images#2094) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - installer: only install `syslinux` when needed (osbuild/images#2089) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - manifest: add `set -e` to `bootc switch...` kickstart %post (osbuild/images#2093) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - many: include legal and license files in ISO (osbuild/images#2099) - Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza - osbuild: drop `valueIn` helper (osbuild/images#2086) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger - readme: update link to image definitions (osbuild/images#2070) - Author: Anna Vítová, Reviewers: Achilleas Koutsou, Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza - test: cross arch build/boot smoke test for ppc64le,s390x (osbuild/images#2069) - Author: Michael Vogt, Reviewers: Lukáš Zapletal, Simon de Vlieger, Tomáš Hozza
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bootc switchcommand we use in our bootc installer ISOs stopped working [0] with the error:However the install continue because while we do set
--erroronfailthe script is not settingset -e.This commit fixes this and makes the bootc switch error in script a hard failure. This means that installs will error currently but its better to error than to install a system that is then not connected to any updates :(
With that the install looks like this:
which is not great but preferable (IMHO) over the current silent error.
[0] osbuild/image-builder-cli#410