Disable skippable boot tests #2075
Conversation
Image types listed under CAN_BOOT_TEST are unconditionally checked for a successful boot when generating the dynamic build pipelines in CI. If specific configurations are skipped when running boot-image, those configurations will always be rebuit in every CI run because they are marked as "CAN_BOOT_TEST" but never get 'boot-success: True' set in their build info. Disable them temporarily until we can perform the same checks during the build config generation.
|
I'm currently working on moving the skip checks to the build configuration, but it might take a while. The rebuilds seem to be causing issues, probably because we've been hitting RHOS usage limits today and the qemu tests run on RHOS runners. |
achilleas-k
force-pushed
the
disable-skippable-boot-tests
branch
from
1f63ee1 to
cc71a97
Compare
|
There are failures such as |
When pytest collects no tests it would exit with status 5. |
...
It seems the issue is that the ostree test get something (the port) appened to the config_name when they are called: $ sudo -E pytest -s -k "rhel-9.8-x86_64-edge-ami-edge-ostree-pull-user-42000" ./testthis is fallout from moving to pytest, sorry for that! |
|
ostree images are still failing 😢 |
|
The ostree builds aren't using the generated configuration, which replaces the ostree URL with a temporary one created for the test by running the ostree container. So the test runs with the example URL in the static configs: |
In osbuild#2045 the script was converted to use pytest. However this does not work for ostree configs. A ostree config must be rewritten so that it points to an actual ostree commit and server. This is done in the `setup_dependencies()` script that then creates a different config/config_name. As this is different from the configs we get via `gen-manifests --dry-run` pytest cannot be used here. So for now be pragmatic and just revert https://github.com/osbuild/images/pull/2045/files#diff-8a0342654218957707e9769f498c86df3f070ee601f5b059f77b30d4d1f50d1eL18 We probably want get back to this eventually and make this setup part of pytest.
mvo5
force-pushed
the
disable-skippable-boot-tests
branch
from
5581938 to
ece732b
Compare
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
All 💚 , let's get this merged!
5 participants
Image types listed under CAN_BOOT_TEST are unconditionally checked for a successful boot when generating the dynamic build pipelines in CI. If specific configurations are skipped when running boot-image, those configurations will always be rebuit in every CI run because they are marked as "CAN_BOOT_TEST" but never get 'boot-success: True' set in their build info.
Disable them temporarily until we can perform the same checks during the build config generation.