packages: propagate excludes for installers #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installers use `installerPkgsKey` to propagate packages necessary for the installer environment. This didn't send through excluded packages leading to depsolve failures on Fedora 40 where both `sdubby` and `grubby` are selected; but `sdubby` conflicts and should be excluded.
ondrejbudai
previously approved these changes
Oct 12, 2023
achilleas-k
previously approved these changes
Oct 12, 2023
|
Disabled the auto-merge; this change breaks dracut as we unconditionally enable modules which are now not available due to excluded packages. I'll update the PR :) |
We explicitly list dracut modules to be enabled, in the live-installer package set we remove a few packages which make these modules unavailable.
supakeen
dismissed stale reviews from thozza, achilleas-k, and ondrejbudai
via
5d153f1
ondrejbudai
approved these changes
Oct 12, 2023
thozza
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installers use
installerPkgsKeyto propagate packages necessary for the installer environment. This didn't send through excluded packages leading to depsolve failures on Fedora 40 where bothsdubbyandgrubbyare selected; butsdubbyconflicts and should be excluded.