Conversation
|
Some error messages need to be updated in tests. |
The issue is actually that the order in which resolver resolves the entries is not stable. |
Oh! Problem. |
supakeen
force-pushed
the
no-clienterror
branch
from
477b4fd to
773a6f3
Compare
|
Rebasing on f0ffe5b. |
The remotefile package provides a content resolver implementation, not a customization. Move it to the pkg/ directory, where also other content resolver packages live. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Rework the remotefile resolver to not embed the resolution error in the Spec definition, but instead return error from the resolver `Finish()` method. This is consistent with i.e. the container resolver. Additionally, don't use clienterrors package for errors. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This is a leftover from osbuild-composer split, while the authoritative copy still lives in osbuild-composer repository. The package is not needed in the images library.
achilleas-k
force-pushed
the
no-clienterror
branch
from
773a6f3 to
2aeb552
Compare
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
For the record, I am picking this PR up since I need this for osbuild/osbuild#2326 |
|
I am taking your commits and pulling them into my own PR, closing this one if you don't mind. |
3 participants
While working on something else, I noticed that we still keep the
internal/workerin this repository, which is a leftover from the osbuild-composer split.To enable the removal, refactor the
remotefilepackage implementation and move it to thepkg/directory, since it has nothing to do with customizations. Theremotefileresolver is not used anywhere, AFAIK, so I could also delete it, but I think we may actually use it for some functionality we discussed in the past (i.e., embedding custom files referenced by a remote URL inimages/pkg/manifest/os.go
Line 1231 in f21ffd7