fedora: disable gpt-auto for ISOs (HMS-9524)
#1948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long bit of debugging went ahead of this, for full details see [1]. We want to inhibit `systemd-gpt-auto-generator` from running on ISOs when they are booted in UEFI mode as it won't be able to find the root partition. This in turn causes the boot to fail. When `systemd-gpt-auto-generator` is prevented from running the boot succeeds so this is likely an ordering issue in when/how things get mounted by `dracut`. This only affects (probably accidentally) non-live media as live-media follows a different path to mount its root and probably runs a bit earlier. The solution here isn't a long-term thing though it's also not bad to leave it in as there's never a need to run `systemd-gpt-auto-generator` on ISOs as far as I'm aware. [1]: osbuild#1947 (comment) Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
requested review from
achilleas-k,
bcl,
lzap,
mvo5 and
thozza
and removed request for
lzap and
mvo5
supakeen
changed the title
gpt-auto for ISOsgpt-auto for ISOs (HMS-9524)
This was referenced Oct 13, 2025
Member
Author
|
Closed in favor of #1949. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long bit of debugging went ahead of this, for full details see 1.
We want to inhibit
systemd-gpt-auto-generatorfrom running on ISOs when they are booted in UEFI mode as it won't be able to find the root partition. This in turn causes the boot to fail.When
systemd-gpt-auto-generatoris prevented from running the boot succeeds so this is likely an ordering issue in when/how things get mounted bydracut.This only affects (probably accidentally) non-live media as live-media follows a different path to mount its root and probably runs a bit earlier.
The solution here isn't a long-term thing though it's also not bad to leave it in as there's never a need to run
systemd-gpt-auto-generatoron ISOs as far as I'm aware.See: osbuild/bootc-image-builder#1073 for bootc.
Draft as I want to have some discussion if we should just blanket apply this everywhere as the problem is likely to pop up in CentOS/RHEL as well.