many: drop Exports() from imagetypes and use the manifest
#1735
Conversation
These calls are unnecessary because the imagePipeline already has the Filename(). They are also "wrong" in some sense because it should be the images function should decide what is exported.
The image functions already mark the exported artifacts so we do not need this information in the image types.
The images functions already know what is exported so drop duplicating this from the imagetypes and use the manifest instead.
|
This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes. This is simply a notice. It will not block this PR from being merged. |
|
Related: #1738 |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
I would still like this. |
4 participants
[draft as it needs consensus first and also needs updates to ibcli/composer, based on the excellent suggestion from @achilleas-k - there is also the question how this will fit with bootc/bib, see https://github.com//pull/1736 which has exports for all of raw/qcow2/etc currently, this side also needs tweaks probably a selector in the images function]
This PR removes the
distro.ImageType.Exports()method and replaces it with themanifest.Exports().