gitlab: run ostree manifest generation and builds only when needed#1961
Merged
Conversation
supakeen
previously approved these changes
Oct 21, 2025
With the way the gitlab-ci.yml was generated before, we've been running some useless jobs. On CentOS 10, RHEL 10, and RHEL 7 distros, there are no ostree-based image types. The 'generate-ostree-build-config' job would then run 'gen-manifests' for ostree-based image type names, produce no manifests, and end successfully with no builds queued for the next step. This is wasteful. Let's stop doing this.
achilleas-k
force-pushed
the
el10/no-ostree
branch
from
c4bf546 to
23bf963
Compare
Member
Author
|
Had to rebase on #1955. |
supakeen
approved these changes
Oct 21, 2025
croissanne
added a commit
to croissanne/osbuild-composer
that referenced
this pull request
Oct 22, 2025
In adapting to the new osbuild/osbuild-exec code, ExportPaths got dropped. This variable / option was not used anywhere anyway. Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/image-builder#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/image-builder#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/image-builder#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
croissanne
added a commit
to croissanne/image-builder-cli
that referenced
this pull request
Oct 22, 2025
Changes with 0.207.0 ---------------- - Enable fedora 43 unit testing (osbuild/image-builder#1954) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - fedora: update cloud_kernel_options (osbuild/image-builder#1953) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - test/data/repos/rhel-10.2: fix copy & paste error (osbuild/image-builder#1956) - Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Simon de Vlieger Changes with 0.208.0 ---------------- - Schutzfile: switch CI runner to Fedora 42 (osbuild/image-builder#1955) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - Support uploading to IBM Cloud (osbuild/image-builder#1924) - Author: Jakub Kadlčík, Reviewers: Achilleas Koutsou, Simon de Vlieger - pkg/osbuild: generate osbuild result from status scanner entries (osbuild/image-builder#1941) - Author: Sanne Raymaekers, Reviewers: Nobody Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/image-builder#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/image-builder#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/image-builder#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
croissanne
added a commit
to osbuild/osbuild-composer
that referenced
this pull request
Oct 22, 2025
In adapting to the new osbuild/osbuild-exec code, ExportPaths got dropped. This variable / option was not used anywhere anyway. Changes with 0.209.0 ---------------- - gitlab: run ostree manifest generation and builds only when needed (osbuild/image-builder#1961) - Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza - osbuild/osbuild-exec: extract building the osbuild cmd to helper (osbuild/image-builder#1963) - Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Simon de Vlieger - rhel10: add ism secret & top secret oscap profiles (HMS-9507) (osbuild/image-builder#1962) - Author: Gianluca Zuccarelli, Reviewers: Lukáš Zapletal, Sanne Raymaekers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the way the gitlab-ci.yml was generated before, we've been running some useless jobs. On CentOS 10, RHEL 10, and RHEL 7 distros, there are no ostree-based image types. The 'generate-ostree-build-config' job would then run 'gen-manifests' for ostree-based image type names, produce no manifests, and end successfully with no builds queued for the next step.
This is wasteful. Let's stop doing this.