Skip to content

test,data: re-add kernel.append to {minimal,image}-installer#1870

Merged
lzap merged 1 commit into
osbuild:mainfrom
mvo5:readd-kernel-append-for-iso
Sep 19, 2025
Merged

test,data: re-add kernel.append to {minimal,image}-installer#1870
lzap merged 1 commit into
osbuild:mainfrom
mvo5:readd-kernel-append-for-iso

Conversation

@mvo5

@mvo5 mvo5 commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

This commit re-adds the kernel.append customization to the {minimal,image}-installer and also add it to the test manifests.

This option was supported via
#1786
but when adding the blueprint options checking via the YAML it seems this support got lost.

[see also https://github.com//pull/1786#issuecomment-3298741353]

@mvo5 mvo5 requested a review from a team as a code owner September 16, 2025 13:25
@mvo5 mvo5 requested review from bcl, lzap and supakeen September 16, 2025 13:25
@mvo5 mvo5 requested a review from achilleas-k September 16, 2025 13:26
@mvo5 mvo5 force-pushed the readd-kernel-append-for-iso branch 2 times, most recently from 09084bb to 4baba6f Compare September 16, 2025 14:22
bcl
bcl previously approved these changes Sep 17, 2025

@bcl bcl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

lzap
lzap previously approved these changes Sep 17, 2025
@supakeen supakeen added this pull request to the merge queue Sep 17, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 17, 2025
@mvo5 mvo5 dismissed stale reviews from lzap and bcl via 408627e September 19, 2025 09:21
@mvo5 mvo5 force-pushed the readd-kernel-append-for-iso branch from 4baba6f to 408627e Compare September 19, 2025 09:21
This commit re-adds the `kernel.append` customization to
the {minimal,image}-installer and also add it to the test
manifests.

This option was supported via
osbuild#1786
but when adding the blueprint options checking via the
YAML it seems this support got lost.
@mvo5 mvo5 force-pushed the readd-kernel-append-for-iso branch from 408627e to 652f101 Compare September 19, 2025 09:22
@mvo5

mvo5 commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, had to force push because of conflicts.

@schutzbot

schutzbot commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

A previous version of this PR changed the images API or behaviour causing integration issues with image-builder-cli.
This is now fixed.

@lzap lzap added this pull request to the merge queue Sep 19, 2025
Merged via the queue into osbuild:main with commit 40f6cde Sep 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants