bootc: add integration test for disk.yaml (HMS-9295)#1835
Closed
mvo5 wants to merge 5 commits into
Closed
Conversation
This commit adds a new `randutil.String()` helper that will generate a random lower/upper/digest/symbols string by default. The implements is inspired by pythons random.choice(), i.e. it is possible to pass a different set of strings to generate the a way to generate the random string from. This is useful to generate random container IDs for example.
We have a more generic way of doing random strings now so lets use it.
This commit introduces a fake bootc container that contains just enough content to simulate a bootc image. It is based on a "FROM scartch" container and does not require a network connection. It will build a static go binary to provide the "sleep" binary and the "bootc" binary that is expected by the bootc introspection code in images. The code to geneate fake bootc containers is put into pkg/distro/bootc/bootctest and can potentially be reused for manifest tests and for ibcli/bib. Thanks to Alex for suggesting the static go binary.
This commit adds support to test for disk.yaml
schutzbot
changed the title
alexlarsson
reviewed
Sep 8, 2025
|
|
||
| manifestJson := genManifest(t, imgType) | ||
| // XXX: test a bit more in-depth | ||
| assert.Contains(t, manifestJson, "org.osbuild.write-device") |
Contributor
There was a problem hiding this comment.
Can we also try with build-container and ensure it writes the file from the right pipeline.
Contributor
Author
|
I messed up the branch name and then when renaming GH just closed it :/ The updated version is now in #1845 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[based on https://github.com//pull/1828]
This commit adds support to test for disk.yaml
/jira-epic HMS-8839
JIRA: HMS-9295