Basic support for aboot support in bootc-image-builder.#1781
Closed
alexlarsson wants to merge 3 commits into
Closed
Basic support for aboot support in bootc-image-builder.#1781alexlarsson wants to merge 3 commits into
alexlarsson wants to merge 3 commits into
Conversation
This allows specifying more GPT partition details, which we need for automotive use, because our images contain pre-generated mount file that refers to these.
UUID already existed in the struct, but we add the ability to customize it via the blueprint, Label was added, with ability to customize via blueprint.
This completes the ability to customize partition labels and uuids.
Contributor
Author
|
Sorry, this was the wrong source branch, created #1782 with the real one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds required features for making bootc-image-builder support aboot images.
The two features are:
Add support for Osinfo to find the kernel dir (/usr/lib/moduler/*) in the target container, and check if it contains an aboot.img. This will be used by bootc-image-builder to trigger the "aboot mode" for the image. This is similar to what was done for
bootc installin bootc-dev/bootc#1532.Support adding a "disk.Raw" payload, that specifies a file from an earlier pipeline and writes it to a device. This uses the new org.ostree.write-device stage (added in v154).
The intent is that bootc-image-builder will detect that there is an aboot.img in the target image, and then find the correct partition in the partition table and add a disk.Raw payload to the raw boot partition to initialize it from the file. The corresponding bc-i-b code is available here: https://github.com/alexlarsson/bootc-image-builder/tree/aboot-support for reading, but will later be a separate PR.
Note: The bc-i-b branch above doesn't build against this PR, because bc-i-b doesn't build against osbuild-images v0.178 due to API changes, but I tested it against v0.177, and it worked.