disk: pass default fs to FS customizations (MS-8990)#1714
Merged
Conversation
Collaborator
|
A previous version of this PR changed the images API or behaviour causing integration issues with osbuild-composer. |
mvo5
force-pushed
the
disk-customizations-fstype
branch
3 times, most recently
from
edb8711 to
d2413cd
Compare
thozza
previously approved these changes
Aug 1, 2025
thozza
left a comment
thozza
left a comment
Member
There was a problem hiding this comment.
Thanks.
In general, this looks OK, I just don't like that the "default" behavior is implemented in two places.
In addition, this made me realize that we should consider defining FSType as an enum or at least as constants, instead of using string literals everywhere.
mvo5
force-pushed
the
disk-customizations-fstype
branch
from
d2413cd to
e4cc000
Compare
achilleas-k
changed the title
Tradtionally we did not pass the filesystem with the filesystem customizations which means that we always created "xfs". This is problematic on bootc systems that require us to use the container default filesystem and arguably also on fedora that declares its default fs to be "ext4" in our image definitions. So this commit changes the behavior so that the defaultFs is passed when creating custom mountpoints. This changes nothing on rhel/centos but does change the behavior on fedora - which should be fine as we can consider this a bugfix. The manifest diff shows that the fstype on fedora moves from xfs to ext4 for the filesystem customizations.
mvo5
force-pushed
the
disk-customizations-fstype
branch
from
e4cc000 to
03400f5
Compare
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Sep 5, 2025
This implements the suggestion by Achilleas to error when CreateMointpoint() in btrfs or lvm is called with the wrong arguments, see osbuild#1714 (comment) Thanks to Achilleas.
mvo5
changed the title
mvo5
changed the title
achilleas-k
previously approved these changes
Sep 10, 2025
achilleas-k
left a comment
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Thank you! LGTM
Typo found.
This implements the suggestion by Achilleas to error when CreateMointpoint() in btrfs or lvm is called with the wrong arguments, see osbuild#1714 (comment) Thanks to Achilleas.
mvo5
force-pushed
the
disk-customizations-fstype
branch
from
ebbed39 to
4175866
Compare
achilleas-k
approved these changes
Sep 10, 2025
supakeen
approved these changes
Sep 15, 2025
Member
|
While this is a bugfix it is also incorrect as Fedora Server should be XFS. That can be done in follow-ups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[needed for https://github.com//pull/1656]
Tradtionally we did not pass the filesystem with the filesystem customizations which means that we always created "xfs". This is problematic on bootc systems that require us to use the container default filesystem and arguably also on fedora that declares its default fs to be "ext4" in our image definitions.
So this commit changes the behavior so that the defaultFs is passed when creating custom mountpoints. This changes nothing on rhel/centos but does change the behavior on fedora - which should be fine as this is a bugfix.
/jira-epic HMS-8844
JIRA: HMS-8990