ibcli: add new --output-name flag and predictable default names#158
Merged
supakeen merged 4 commits intoosbuild:mainfrom Mar 14, 2025
Merged
ibcli: add new --output-name flag and predictable default names#158supakeen merged 4 commits intoosbuild:mainfrom
supakeen merged 4 commits intoosbuild:mainfrom
Conversation
mvo5
force-pushed
the
output-filename-after-the-fact
branch
2 times, most recently
from
e252a54 to
b08bb7e
Compare
mvo5
changed the title
mvo5
force-pushed
the
output-filename-after-the-fact
branch
3 times, most recently
from
9eb14ae to
3b2fe54
Compare
mvo5
force-pushed
the
output-filename-after-the-fact
branch
from
6bac826 to
91554e1
Compare
mvo5
changed the title
mvo5
changed the title
This commit adds a new `--output-name` flag that will rename the resulting artifact after it was build. All auxillary artifacts like buildlog, sbom etc are also name based on the same basename. See also osbuild/images#1039 for how this could be simpler (especially the fake osbuild). Closes: osbuild#43
A tiny helper to run a specific function inside a different dir, useful in our testsuite.
mvo5
force-pushed
the
output-filename-after-the-fact
branch
from
91554e1 to
6e7156d
Compare
supakeen
approved these changes
Mar 14, 2025
Member
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
I ❤️ this, thank you. I'm perfectly fine with --output-name as that name makes sense to me, it only gets murky when combined with --output-dir, but not much.
For other readers, this would hugely simplify renaming and other bits and bobs I currently would need to do for koji integration.
supakeen
reviewed
Mar 14, 2025
A small test for a basename that includes dotted parts (as used by for example Fedora's buildsystem). Also some code changes to make this test pass, it seems that SBOM base was determined based on some other filename which is now no longer relevant? Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
approved these changes
Mar 14, 2025
Member
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
Fixed a tiny bug. All seems good now (but weird to approve a PR with my own commits).
achilleas-k
reviewed
Mar 14, 2025
achilleas-k
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new
--output-nameflag that will rename the resulting artifact after it was build. All auxillary artifacts like buildlog, sbom etc are also name based on the same basename.One open question is if this should be "--output-filename" or "--basename".
See also osbuild/images#1039 for how
this could be simpler (especially the fake osbuild).
As a side-effect this will now produce more predictable names by default as well: