bib: mark rpm based ISOs internally as deprecated#1063
Merged
mvo5 merged 4 commits intoosbuild:mainfrom Oct 1, 2025
Merged
Conversation
Tiny cleanup/refactor to move some code out of {main,images}.go
so that those places are less cluttered.
During the refactor the `manifestFromCobra()` helper became quite messy. This commit cleans this up by moving the parts that deal with disk images into their own helper and the part that deals with iso the same.
This commit moves the rpm based ISO handling from images.go and main.go into the new legacy_iso.go file to make clear that the parts in there are only needed for the legacy (rpm) ISO handling and can be removed once we no longer need to support this.
We want to move into a world where we build the anaconda image from bootc containers instead of our current RPM based construction [0] so lets mark the rpm based installer ISO image types as legacy. This should make it easy to support a potential new `bootc-iso` or `bootc-installer` image type [0] while still supporting the legacy mode for a while.
mvo5
requested review from
achilleas-k,
croissanne and
supakeen
and removed request for
a team
achilleas-k
approved these changes
Sep 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
supakeen
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some code cleanup/reshuffling to separate the legacy rpm bsased ISO building from the "new" images library manifest creation. Once we support "bootc" based installer containers the "new" images code path will also be used for those.
This assume of course that something like #1059 is the future how we want the ISOs to be constructed.