Add drgn.Program.main_thread() #157
Conversation
osandov
left a comment
osandov
left a comment
There was a problem hiding this comment.
Thanks for taking this! The scaffolding all looks right here, but I commented on where we should be getting the main TID from.
mykola-lysenko
force-pushed
the
issue_144
branch
2 times, most recently
from
04241e6 to
2d69fd9
Compare
osandov
left a comment
osandov
left a comment
There was a problem hiding this comment.
A few more minor things, thanks!
mykola-lysenko
force-pushed
the
issue_144
branch
from
2d69fd9 to
bfa399b
Compare
osandov
left a comment
osandov
left a comment
There was a problem hiding this comment.
Thanks, this all looks functionally correct, I just had a few final nitpicks.
mykola-lysenko
force-pushed
the
issue_144
branch
from
bfa399b to
6888352
Compare
Currently only supported for user-space crash dumps. E.g. no support for live user-space application debugging or kernel debugging. Closes osandov#144. Signed-off-by: Mykola Lysenko <[email protected]>
osandov
left a comment
osandov
left a comment
There was a problem hiding this comment.
I did some copy editing, added some trivial Linux kernel test cases that assert that main_thread() raises an exception, and added a reference to main_thread() to the user guide. Once the test cases pass, I'll merge this. Thanks!
Thanks a lot @osandov for the review and all the guidance! I have learned a lot |
2 participants
Currently only supported for user-space crash dumps. E.g. no support
for live user-space application debugging of kernel debugging
Closes #144
Signed-off-by: Mykola Lysenko [email protected]