TEMP: e2e verification for OSAC-3528 hotfix (do not merge) by eliorerz · Pull Request #71 · osac-project/osac

eliorerz · 2026-08-01T14:41:55Z

Throwaway PR to exercise osac-project/osac-test-infra#293's chart-version-override hotfix (scoping the yq 0.0.0 override to file:// deps so osac-ui's real oci:// dependency isn't broken). Points the bmaas caller's uses: at eliorerz/osac-test-infra@osac-3528-drop-dead-osac-ui-followup. Will be closed (not merged) once verified. See osac-project/osac-test-infra#293 for the real PR.

Summary by CodeRabbit

Tests
- End-to-end BMaaS, CaaS, and VMaaS installation checks now run against the pull request’s source branch when applicable.
- Improved validation of changes from forks and alternate branches during full-install testing.
- Removed redundant BMaaS and VMaaS installation workflows from the installer project to centralize test execution.

…onents Pass installer-repo/installer-ref through to the e2e reusable workflows so PRs touching fulfillment-service, osac-operator, osac-aap, or bare-metal-fulfillment-operator deploy osac-installer from the same fork/ref, matching the existing components[].repo/.ref pattern. Also removes the two nested e2e workflow files under osac-installer/.github/ that GitHub never discovers there (workflows only run from the repo root's .github/workflows/) and that duplicated the root callers.

openshift-ci · 2026-08-01T14:42:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [eliorerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-08-01T14:42:17Z

Walkthrough

The root BMaaS, CaaS, and VMaaS workflows now pass explicit installer repository and ref inputs. BMaaS uses a new reusable workflow source. The installer’s nested BMaaS and VMaaS workflows were removed.

Changes

Installer source routing

Layer / File(s)	Summary
Propagate installer repository and ref inputs `.github/workflows/e2e-bmaas-full-install.yml`, `.github/workflows/e2e-caas-full-install.yml`, `.github/workflows/e2e-vmaas-full-install.yml`	The workflows derive installer repository and ref values from pull request sources, with current repository and ref fallbacks for other events. The BMaaS reusable workflow reference now uses the specified `eliorerz` ref.
Remove nested full-install workflows `osac-installer/.github/workflows/e2e-bmaas-full-install.yml`, `osac-installer/.github/workflows/e2e-vmaas-full-install.yml`	The nested BMaaS and VMaaS workflows were deleted, including their triggers and reusable workflow invocations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

osac-project/osac#67: Modifies the same E2E workflows and installer repository/ref inputs.
osac-project/osac#70: Modifies the same E2E workflows and BMaaS reusable workflow reference.
osac-project/osac#32: Modifies the BMaaS and VMaaS full-install workflow inputs.

Suggested labels: ok-to-test

Suggested reviewers: rgolangh

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the temporary E2E verification for the OSAC-3528 hotfix and states that the pull request must not be merged.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	PR additions contain only workflow references, comments, and GitHub expressions; scans found no secret literals, credential-bearing URLs, private keys, or long base64 strings.
No-Weak-Crypto	✅ Passed	The full PR diff only changes GitHub Actions workflow references, inputs, comments, and deletes duplicate workflows; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation.
No-Injection-Vectors	✅ Passed	The PR only changes reusable-workflow inputs and references; PR-derived values stay in `with` fields, with no SQL concatenation, shell=True, eval/exec, pickle.loads, yaml.load, os.system, or danger...
Container-Privileges	✅ Passed	The only changed file updates a reusable workflow ref; it adds no container/Kubernetes privilege fields, root execution settings, host namespaces, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs	✅ Passed	The cumulative diff adds no logging commands or secret/PII values; caller logs only upstream job result statuses, and deleted workflows contained no logging.
Ai-Attribution	✅ Passed	The PR description and both PR commits contain no AI-tool mention; no AI attribution trailer is required, and no Co-Authored-By trailer appears.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e-bmaas-full-install.yml:
- Line 70: Update the reusable workflow reference in the uses declaration to
replace the mutable osac-3528-drop-dead-osac-ui-followup ref with the full
40-character immutable commit SHA, preserving the existing workflow path and
organization.
- Line 80: Replace the mutable installer-ref expression with the pull request
head SHA for PR events and github.sha otherwise in all three callers:
.github/workflows/e2e-bmaas-full-install.yml:80,
.github/workflows/e2e-caas-full-install.yml:87, and
.github/workflows/e2e-vmaas-full-install.yml:87. Keep the installer-ref key
unchanged while ensuring each workflow uses immutable revisions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 11449623-9c21-499b-90a9-66db9c0e909a

📥 Commits

Reviewing files that changed from the base of the PR and between aab492a and 932b356.

📒 Files selected for processing (5)

.github/workflows/e2e-bmaas-full-install.yml
.github/workflows/e2e-caas-full-install.yml
.github/workflows/e2e-vmaas-full-install.yml
osac-installer/.github/workflows/e2e-bmaas-full-install.yml
osac-installer/.github/workflows/e2e-vmaas-full-install.yml

💤 Files with no reviewable changes (2)

osac-installer/.github/workflows/e2e-bmaas-full-install.yml
osac-installer/.github/workflows/e2e-vmaas-full-install.yml

coderabbitai · 2026-08-01T14:46:21Z

    needs: changes
    if: needs.changes.outputs.should-run == 'true'
-    uses: osac-project/osac-test-infra/.github/workflows/e2e-bmaas-full-install.yml@main
+    uses: eliorerz/osac-test-infra/.github/workflows/e2e-bmaas-full-install.yml@osac-3528-drop-dead-osac-ui-followup


🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash set -euo pipefail sha="$( git ls-remote --exit-code \ https://github.com/eliorerz/osac-test-infra.git \ refs/heads/osac-3528-drop-dead-osac-ui-followup | awk 'NR == 1 { print $1 }' )" [[ "$sha" =~ ^[0-9a-f]{40}$ ]] printf '%s\n' "$sha"

Repository: osac-project/osac

Length of output: 196

🏁 Script executed:

#!/usr/bin/env bash set -euo pipefail echo "== workflow snippet ==" sed -n '1,120p' .github/workflows/e2e-bmaas-full-install.yml echo echo "== all uses in workflow ==" rg -n "uses:|GITHUB_TOKEN|permissions:|pull_request_target|checkout|pull-request" .github/workflows/e2e-bmaas-full-install.yml

Repository: osac-project/osac

Length of output: 6029

Pin the reusable workflow to an immutable commit.

eliorerz/osac-test-infra is referenced with the mutable branch osac-3528-drop-dead-osac-ui-followup at line 70. Use the full 40-character commit SHA for this ref or switch the branch to a pinned SHA before merging.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/e2e-bmaas-full-install.yml at line 70, Update the reusable workflow reference in the uses declaration to replace the mutable osac-3528-drop-dead-osac-ui-followup ref with the full 40-character immutable commit SHA, preserving the existing workflow path and organization.

Source: Path instructions

coderabbitai · 2026-08-01T14:46:21Z

+      # must deploy from this PR's own fork/ref, not the reusable workflow's
+      # standalone-repo default.
+      installer-repo: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
+      installer-ref: ${{ github.event.pull_request.head.ref || github.ref_name }}


🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Use immutable installer revisions in all three callers.

Each installer-ref uses a mutable repository ref. Use github.event.pull_request.head.sha for pull request events and github.sha for non-PR events in all three workflows.

.github/workflows/e2e-bmaas-full-install.yml#L80

.github/workflows/e2e-caas-full-install.yml#L87

.github/workflows/e2e-vmaas-full-install.yml#L87

📍 Affects 3 files

.github/workflows/e2e-bmaas-full-install.yml#L80-L80 (this comment)

.github/workflows/e2e-caas-full-install.yml#L87-L87

.github/workflows/e2e-vmaas-full-install.yml#L87-L87

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/e2e-bmaas-full-install.yml at line 80, Replace the mutable installer-ref expression with the pull request head SHA for PR events and github.sha otherwise in all three callers: .github/workflows/e2e-bmaas-full-install.yml:80, .github/workflows/e2e-caas-full-install.yml:87, and .github/workflows/e2e-vmaas-full-install.yml:87. Keep the installer-ref key unchanged while ensuring each workflow uses immutable revisions.

eliorerz · 2026-08-01T15:21:50Z

Verification complete. The e2e-bmaas run against this branch (pointed at eliorerz/osac-test-infra@osac-3528-drop-dead-osac-ui-followup) passed end to end, including Install OSAC (which previously failed trying to fetch a nonexistent osac-ui:0.0.0 OCI chart) and Run E2E tests. Closing without merging per this PR's stated purpose -- the real fix is in osac-test-infra#293, which has already merged.

NO_ISSUE: update osac-aap to latest

…-e2e OSAC-2920: Add BMaaS E2E caller workflow

NO-ISSUE: Remove published filtering as public API servers only published catal…

eliorerz added 2 commits August 1, 2026 10:06

TEMP: point bmaas e2e at test-infra hotfix branch for verification

932b356

openshift-ci Bot requested review from larsks and vladikr August 1, 2026 14:42

openshift-ci Bot added the approved label Aug 1, 2026

eliorerz temporarily deployed to e2e-test August 1, 2026 14:42 — with GitHub Actions Inactive

eliorerz had a problem deploying to e2e-test August 1, 2026 14:42 — with GitHub Actions Error

coderabbitai Bot requested changes Aug 1, 2026

View reviewed changes

eliorerz closed this Aug 1, 2026

eliorerz deleted the osac-3528-e2e-verify-temp branch August 1, 2026 15:21

This was referenced Aug 2, 2026

TEMP: e2e verification for OSAC-3509 (do not merge) #79

Closed

OSAC-3513: Repoint osac-aap AAP git-URI default and playbook paths at the mono-repo #72

Merged

OSAC-2801: Add CaaS Netris full-install E2E workflow #110

Merged

ajamias pushed a commit to ajamias/osac that referenced this pull request Aug 3, 2026

Merge pull request osac-project#71 from omer-vishlitzky/main

84fc4ee

NO_ISSUE: update osac-aap to latest

ajamias pushed a commit to ajamias/osac that referenced this pull request Aug 3, 2026

Merge pull request osac-project#71 from carbonin/feat/OSAC-2920-bmaas…

c7e68d4

…-e2e OSAC-2920: Add BMaaS E2E caller workflow

This was referenced Aug 6, 2026

NO-ISSUE: Restore e2e-caas-netris-full-install as on-demand only #169

Closed

OSAC-3734: rename E2E gate jobs for merge queue compatibility #222

Merged

eliorerz pushed a commit that referenced this pull request Sep 18, 2026

Merge pull request #71 from rawagner/catalog_item_published

349c85b

NO-ISSUE: Remove published filtering as public API servers only published catal…

Navigation Menu

Repository navigation

TEMP: e2e verification for OSAC-3528 hotfix (do not merge) - #71

TEMP: e2e verification for OSAC-3528 hotfix (do not merge)#71
eliorerz wants to merge 2 commits into
osac-project:mainfrom
eliorerz:osac-3528-e2e-verify-temp

eliorerz commented Aug 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci Bot commented Aug 1, 2026

Uh oh!

coderabbitai Bot commented Aug 1, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Aug 1, 2026

Uh oh!

coderabbitai Bot Aug 1, 2026

Uh oh!

eliorerz commented Aug 1, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

eliorerz commented Aug 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Aug 1, 2026

Uh oh!

coderabbitai Bot commented Aug 1, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

eliorerz commented Aug 1, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

eliorerz commented Aug 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 1, 2026 •

edited by openshift-ci Bot

Loading