OSAC-1110, OSAC-1111: UI design for Storage Backend and Tier catalogs - #112
ElayAharoni wants to merge 3 commits into
Conversation
Specifies the osac-ui implementation for the StorageBackend (OSAC-1111) and StorageTier (OSAC-1110) admin catalogs: a combined "Storage" nav entry with Backends and Tiers tabs, full CRUD hooks, lifecycle-state actions, and the masked-credential and immutable-field-on-edit form primitives neither resource has precedent for in this codebase. Both fulfillment-service protos are design-stage only; this UI work is blocked on their merge and a subsequent pnpm gen-types run. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Elay Aharoni <elayaha@gmail.com>
|
@ElayAharoni: This pull request references OSAC-1110 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. This pull request references OSAC-1111 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElayAharoni The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cut the StorageBackend admin screen (create/edit/delete, lifecycle actions, masked-credential input) after review: neither PRD states a UI requirement, and StorageBackend is structurally identical to NetworkClass, which this codebase already manages via direct API access with zero CRUD UI. StorageBackend is now consumed only through a minimal read-only hook module for the Tier form's backend picker and the Tier list table's name lookup, mirroring the existing useNetworkClasses()/instance-types.ts pattern. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Elay Aharoni <elayaha@gmail.com>
Decomposition review surfaced that the design assumed an existing "Administration" nav section (with a "Catalog management" entry) to add alongside — that section and its role-gating were fully removed on 2026-07-30 (commit 5ccf669) when the feature that used them (OSAC-2932) was reverted. navRowsForRole currently ignores role entirely. This design now reintroduces role-gated admin navigation and a matching role-conditional route from scratch, using the removed code's exact shape as a reference pattern, which is a stronger design than the original (adds a real route-level guard, not just nav-hiding). Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Elay Aharoni <elayaha@gmail.com>
|
Update: decomposition review ( 🤖 Generated with Claude Code |
|
Superseded by osac-project/enhancement-proposals#183 — per follow-up direction, this design doc is published to the enhancement-proposals repo (alongside the existing StorageTier PRD/design.md) instead of living in osac-ui's own docs/ folder. |
Summary
docs/storage-ui-design.md: the osac-ui implementation design forStorageTier(OSAC-1110), a single "Storage tiers" admin list page for composing named tier offerings from registeredStorageBackend(OSAC-1111) infrastructure.StorageBackendgets no admin UI in this design — neither PRD states a UI requirement, and it's structurally identical toNetworkClass, which this codebase already manages via direct API access with zero CRUD screen.StorageBackendis consumed only through a minimal read-only hook (List/Get) for the Tier form's backend picker and the Tier list table's name lookup.Context
StorageBackendnorStorageTierhas merged in fulfillment-service yet; bothdesign.mddocs are treated as a fixed contract. This UI work is blocked on that merge + apnpm gen-typesrun (both protos are needed even though only Tier gets a CRUD UI), and is submitted now as a design-only doc.Test plan
🤖 Generated with Claude Code