Repository navigation
OSAC-1675: Make e2e workflow reusable across repos #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eliorerz
merged 2 commits into
osac-project:main
from
eliorerz:OSAC-1675-shared-e2e-workflow
Jun 22, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argument injection and word-splitting risks in Helm override parsing.
The current approach has two issues:
Argument injection via keys: A malicious JSON key like
{"--values /etc/passwd": "x"}would produce--set --values /etc/passwd=x, allowing arbitrary Helm flags to be injected.Word splitting on values: Since
${SET_ARGS}is expanded unquoted (line 259), values containing spaces break into separate arguments, causing incorrect Helm behavior.Consider using an array to safely accumulate arguments:
🔒 Proposed fix using bash array for safe argument handling
if [[ -n "${IMAGE_OVERRIDES}" ]] && [[ "${IMAGE_OVERRIDES}" != "{}" ]]; then echo "Applying image overrides..." - SET_ARGS="" - for key in $(echo "${IMAGE_OVERRIDES}" | jq -r 'keys[]'); do - value=$(echo "${IMAGE_OVERRIDES}" | jq -r --arg k "${key}" '.[$k]') - SET_ARGS="${SET_ARGS} --set ${key}=${value}" - echo " --set ${key}=${value}" + SET_ARGS=() + while IFS= read -r key; do + value=$(echo "${IMAGE_OVERRIDES}" | jq -r --arg k "${key}" '.[$k]') + # Validate key doesn't start with - to prevent argument injection + if [[ "${key}" == -* ]]; then + echo "ERROR: Invalid override key '${key}' - keys cannot start with -" >&2 + exit 1 + fi + SET_ARGS+=(--set "${key}=${value}") + echo " --set ${key}=${value}" - done + done < <(echo "${IMAGE_OVERRIDES}" | jq -r 'keys[]') yq -i '(.dependencies[].version) = "0.0.0"' charts/osac/Chart.yaml helm dependency update charts/osac/ helm upgrade osac charts/osac/ \ --namespace "${INSTALLER_NAMESPACE}" \ --values "${VALUES_FILE}" \ - ${SET_ARGS} \ + "${SET_ARGS[@]}" \ --timeout 10m \ --wait fi🤖 Prompt for AI Agents
Source: Coding guidelines