Skip to content

NO-ISSUE: Stop running CaaS/Netris e2e on every PR - #336

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:remove-netris-pr-trigger
Aug 7, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:remove-netris-pr-trigger

Conversation

@eliorerz

@eliorerz eliorerz commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Why

The CaaS/Netris e2e job (e2e-caas-netris-full-install-caller.yml) is currently failing, and it's expensive to run automatically on every PR touching osac-test-infra -- it provisions a real EC2 c5n.metal box and runs a full Netris Spectrum-X simulated lab + OCP SNO + OSAC install.

What

Drop the pull_request trigger. workflow_dispatch remains, so it's still runnable on demand.

Checked this file's history first: it has never had a schedule trigger, so there's no periodic run to preserve here -- the periodic CaaS/Netris run lives in osac/osac's own caller workflow (which has its own separate schedule), untouched by this change.

Also cleaned up the now-dead PR-only concurrency conditionals (github.event.pull_request.number, cancel-in-progress keyed on pull_request) -- behavior-preserving for the workflow_dispatch trigger that remains, since it already effectively fell back to run_id/false for that event type.

Summary by CodeRabbit

  • Chores
    • End-to-end installation checks no longer run automatically for pull requests targeting the main branch.
    • Checks remain available for manual execution.
    • Parallel workflow runs now complete independently without canceling earlier runs.

This job is currently failing, and it's expensive (real EC2
c5n.metal provisioning + full Netris lab + OCP SNO + OSAC install)
to run automatically on every PR touching osac-test-infra. Drop the
pull_request trigger; workflow_dispatch remains for manual/on-demand
runs. This file never had a schedule trigger to begin with, so there
is no periodic run here to preserve -- the periodic CaaS/Netris run
lives in osac/osac's own caller workflow, unaffected by this change.
@openshift-ci-robot

Copy link
Copy Markdown

@eliorerz: This pull request explicitly references no jira issue.

Details

In response to this:

Why

The CaaS/Netris e2e job (e2e-caas-netris-full-install-caller.yml) is currently failing, and it's expensive to run automatically on every PR touching osac-test-infra -- it provisions a real EC2 c5n.metal box and runs a full Netris Spectrum-X simulated lab + OCP SNO + OSAC install.

What

Drop the pull_request trigger. workflow_dispatch remains, so it's still runnable on demand.

Checked this file's history first: it has never had a schedule trigger, so there's no periodic run to preserve here -- the periodic CaaS/Netris run lives in osac/osac's own caller workflow (which has its own separate schedule), untouched by this change.

Also cleaned up the now-dead PR-only concurrency conditionals (github.event.pull_request.number, cancel-in-progress keyed on pull_request) -- behavior-preserving for the workflow_dispatch trigger that remains, since it already effectively fell back to run_id/false for that event type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 819e14a5-353f-4908-97c4-2ba5afacc4cb

📥 Commits

Reviewing files that changed from the base of the PR and between 452e876 and 0377c1b.

📒 Files selected for processing (1)
  • .github/workflows/e2e-caas-netris-full-install-caller.yml

Walkthrough

The workflow now runs only through manual dispatch. Each run uses its own concurrency group, and active runs are not canceled.

Changes

Workflow execution policy

Layer / File(s) Summary
Trigger and concurrency configuration
.github/workflows/e2e-caas-netris-full-install-caller.yml
The workflow no longer triggers for pull requests targeting main. Concurrency uses the current run ID, and in-progress runs remain active.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: danmanor

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing automatic CaaS/Netris end-to-end runs from every pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The pull request adds only a run-ID concurrency group and cancel-in-progress: false; scans found no secret identifiers, credential URLs, private-key markers, or long base64 literals.
No-Weak-Crypto ✅ Passed The patch changes only workflow triggers and concurrency; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
No-Injection-Vectors ✅ Passed The diff only removes the pull_request trigger and adds a run_id-based concurrency group with false cancellation; it adds no listed injection sink or untrusted-data interpolation.
Container-Privileges ✅ Passed The only changed file removes a PR trigger and changes concurrency; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The patch only changes workflow triggers and concurrency; it adds no logging, secret interpolation, or output of sensitive values.
Ai-Attribution ✅ Passed The authored PR description and head commit do not mention an AI tool; the head commit has no Assisted-by, Generated-by, or AI Co-Authored-By trailer.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@eliorerz
eliorerz merged commit d1b108f into osac-project:main Aug 7, 2026
3 of 5 checks passed

This branch had an error being deployed

1 failed deployment
e2e-test — 0377c1b6 Deployed Aug 7, 2026 by eliorerz via e2e-vmaas-full-install / e2e #912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants