Repository navigation
NO-ISSUE: Stop running CaaS/Netris e2e on every PR - #336
Conversation
This job is currently failing, and it's expensive (real EC2 c5n.metal provisioning + full Netris lab + OCP SNO + OSAC install) to run automatically on every PR touching osac-test-infra. Drop the pull_request trigger; workflow_dispatch remains for manual/on-demand runs. This file never had a schedule trigger to begin with, so there is no periodic run here to preserve -- the periodic CaaS/Netris run lives in osac/osac's own caller workflow, unaffected by this change.
|
@eliorerz: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow now runs only through manual dispatch. Each run uses its own concurrency group, and active runs are not canceled. ChangesWorkflow execution policy
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Why
The CaaS/Netris e2e job (
e2e-caas-netris-full-install-caller.yml) is currently failing, and it's expensive to run automatically on every PR touchingosac-test-infra-- it provisions a real EC2c5n.metalbox and runs a full Netris Spectrum-X simulated lab + OCP SNO + OSAC install.What
Drop the
pull_requesttrigger.workflow_dispatchremains, so it's still runnable on demand.Checked this file's history first: it has never had a
scheduletrigger, so there's no periodic run to preserve here -- the periodic CaaS/Netris run lives inosac/osac's own caller workflow (which has its own separateschedule), untouched by this change.Also cleaned up the now-dead PR-only concurrency conditionals (
github.event.pull_request.number,cancel-in-progresskeyed onpull_request) -- behavior-preserving for theworkflow_dispatchtrigger that remains, since it already effectively fell back torun_id/falsefor that event type.Summary by CodeRabbit