MGMT-22635: fix test defaults for CI environment

[omer-vishlitzky]

Summary

• Change default CLI binary from fulfillment-cli to osac (renamed in fulfillment-service#399)
• Fix OSAC_NETWORK_CLASS default from osac.templates.cudn_net to cudn_net to match actual NetworkClass implementation_strategy value

Ref

https://redhat.atlassian.net/browse/MGMT-22635

Summary by CodeRabbit

• Chores
  • Updated test fixture configurations for improved consistency across test suites.

[openshift-ci-robot]

@omer-vishlitzky: This pull request references MGMT-22635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Change default CLI binary from fulfillment-cli to osac (renamed in fulfillment-service#399)
• Fix OSAC_NETWORK_CLASS default from osac.templates.cudn_net to cudn_net to match actual NetworkClass implementation_strategy value

Ref

https://redhat.atlassian.net/browse/MGMT-22635

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07430b6c-8eeb-43b6-943b-e5bae56ecf67

📥 Commits

Reviewing files that changed from the base of the PR and between f5174fa and 5f09fce.

📒 Files selected for processing (2)

• tests/conftest.py
• tests/vmaas/conftest.py

---

Walkthrough

Two fixture default values were updated in test configuration files. The first change modifies the CLI executable path from "fulfillment-cli" to "osac" in the main conftest. The second simplifies the network class reference from "osac.templates.cudn_net" to "cudn_net" in the vmaas test configuration. Both are single-line modifications to environment variable fallback values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

Suggested reviewers

• adriengentil
• tzumainn
• jhernand

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing test defaults for CI environment, which aligns with the core objective of updating fixture defaults in conftest files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[akshaynadkarni]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaynadkarni, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [akshaynadkarni,omer-vishlitzky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment