Repository navigation
OSAC-1330: update E2E tests for type-safe resource references - #272
htayrie-rh wants to merge 4 commits into
Conversation
Wrap reference fields in typed reference objects ({id: ...} or
{name: ...}) to match the new wire format from fulfillment-service.
Changes:
- grpc_client.py: wrap all reference fields sent in gRPC requests
- catalog conftest: network_class fixture returns name instead of id
- catalog lifecycle tests: update assertions and inline calls
- external_ip conftest: update pool/attachment cleanup assertions
Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Haim Tayrie <htayrie@htayrie-thinkpadt14gen5.raanaii.csb>
|
@htayrie-rh: This pull request references OSAC-1330 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: htayrie-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe test gRPC client now sends nested resource references and template objects. Catalog lifecycle tests and fixtures validate the corresponding response shapes, while ExternalIP cleanup reads nested reference IDs. ChangesNested reference shapes
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The E2E tests were using "cudn_net" (implementation_strategy format
with underscores) as the network_class value. With type-safe references,
this value is sent as {"name": "cudn_net"} and looked up against
metadata.name, which is "cudn-net" (DNS-label format with hyphens).
Change the default from "cudn_net" to "cudn-net" to match the
NetworkClass's metadata.name.
Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Haim Tayrie <htayrie@htayrie-thinkpadt14gen5.raanaii.csb>
…name format Template fixtures sent Ansible collection IDs (e.g. osac.templates.ocp_virt_vm) as reference names, but the reference validator now looks up by metadata.name (DNS-label format, e.g. ocp-virt-vm). Update all fixture defaults and env var documentation to use metadata.name format. Signed-off-by: Hector Tayrie <htayrie@redhat.com> Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Haim Tayrie <htayrie@htayrie-thinkpadt14gen5.raanaii.csb>
The type-safe references PR changed template lookups to use metadata.name (DNS-label format). Update the BMaaS E2E workflow default from the old dotted ID to the new format. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Haim Tayrie <htayrie@htayrie-thinkpadt14gen5.raanaii.csb>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Superseded by #296, which was merged on Aug 5. |
This branch was previously deployed
2 participants
Summary
{"id": ...}or{"name": ...}) to match the new wire format from fulfillment-service PR #986GRPCClientmethods:create_compute_instance,update_restart,create_virtual_network,create_subnet,create_security_group,create_external_ip,create_external_ip_attachment, and all three catalog item create methodstemplate,catalogItem,pool,external_ip)network_classfixture in catalog conftest to returnmetadata.nameinstead ofidTest plan
Depends on osac-project/fulfillment-service#986
Assisted-by: Claude Code noreply@anthropic.com
Summary by CodeRabbit
Bug Fixes
Tests