Repository navigation
MGMT-22799: add Containerfile for pytest test image - #19
Conversation
Self-contained image with all tools needed to run the e2e test suite on a bare metal machine via podman. Depends on osac-project#18 (pyproject.toml and uv.lock must exist).
|
@omer-vishlitzky: This pull request references MGMT-22799 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eranco74
left a comment
eranco74
left a comment
There was a problem hiding this comment.
LGTM. Clean Containerfile that packages the test suite with all dependencies.
Minor follow-up suggestions (non-blocking, already merged):
- Pin UBI base image to specific version for reproducibility
- Add non-root USER directive
- Consider checksum verification for downloaded binaries
- Optimize layer caching by copying pyproject.toml/uv.lock before test code
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, eranco74, omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
https://redhat.atlassian.net/browse/MGMT-22799
Self-contained container image for running the e2e test suite on bare metal machines via podman.
Contents:
Depends on #18 (pyproject.toml and uv.lock must exist on main).