Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

OSAC-1768: Add storage controller to Helm chart - #320

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:OSAC-1768-add-storage-controller-to-helm
Jun 26, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:OSAC-1768-add-storage-controller-to-helm

Conversation

@eliorerz

Copy link
Copy Markdown
Contributor

Summary

  • Add OSAC_ENABLE_STORAGE_CONTROLLER env var to the operator Helm chart deployment template
  • Add controllers.storageController to chart values (default: false)
  • Without this, the Storage Controller never runs in Helm deployments, leaving Tenant.Status.StorageClasses empty and causing all ComputeInstance provisioning to fail

Test plan

  • Enable storageController: true in CI values
  • Run e2e-full-install and verify ComputeInstance tests pass

The OSAC_ENABLE_STORAGE_CONTROLLER env var was missing from the
operator Helm chart, so the Storage Controller never ran in
Helm-based deployments. Without it, Tenant.Status.StorageClasses
is never populated, causing all ComputeInstance provisioning to
fail with "no tenant_storage_classes available".

Default to false to avoid breaking existing deployments.
@openshift-ci-robot

openshift-ci-robot commented Jun 24, 2026

Copy link
Copy Markdown

@eliorerz: This pull request references OSAC-1768 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add OSAC_ENABLE_STORAGE_CONTROLLER env var to the operator Helm chart deployment template
  • Add controllers.storageController to chart values (default: false)
  • Without this, the Storage Controller never runs in Helm deployments, leaving Tenant.Status.StorageClasses empty and causing all ComputeInstance provisioning to fail

Test plan

  • Enable storageController: true in CI values
  • Run e2e-full-install and verify ComputeInstance tests pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from trewest and tzvatot June 24, 2026 23:39
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@eliorerz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 36 minutes and 37 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 85300b62-7d56-4684-8add-8a8663a1a0c1

📥 Commits

Reviewing files that changed from the base of the PR and between 8220502 and 08991cc.

📒 Files selected for processing (2)
  • charts/operator/templates/deployment.yaml
  • charts/operator/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eliorerz eliorerz added the lgtm label Jun 26, 2026
@eliorerz
eliorerz merged commit 773d078 into osac-project:main Jun 26, 2026
11 checks passed
@eliorerz
eliorerz deleted the OSAC-1768-add-storage-controller-to-helm branch June 26, 2026 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants