Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

NO-ISSUE: Add public IP pools to kustomize - #190

Merged
danmanor merged 1 commit into
osac-project:mainfrom
danmanor:fix-base
Apr 20, 2026
Merged

danmanor merged 1 commit into
osac-project:mainfrom
danmanor:fix-base

Conversation

@danmanor

@danmanor danmanor commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

publicIPPools CRD was added but was not included as a kustomize resource

@openshift-ci-robot

Copy link
Copy Markdown

@danmanor: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from jhernand April 20, 2026 10:56
@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c7beaf60-805a-4b70-ad02-ad28d52c8aa8

📥 Commits

Reviewing files that changed from the base of the PR and between ad29a1e and e377d4a.

📒 Files selected for processing (1)
  • config/crd/kustomization.yaml

📝 Walkthrough

Walkthrough

Added a single CRD resource reference (bases/osac.openshift.io_publicippools.yaml) to the kustomization manifest's resources list, enabling the CustomResourceDefinition for public IP pools to be included in the build configuration.

Changes

Cohort / File(s) Summary
CRD Configuration
config/crd/kustomization.yaml
Added bases/osac.openshift.io_publicippools.yaml CRD resource entry to the resources list in kustomization manifest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • trewest
  • tzvatot

Poem

🐰 A tiny hop through kustomization,
One CRD joins the celebration!
Public pools now included with care,
Resources manifest, perfectly paired. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding public IP pools to the kustomization configuration file, which directly matches the changeset modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danmanor
danmanor merged commit 96060fc into osac-project:main Apr 20, 2026
8 checks passed
wgordon17 pushed a commit to wgordon17/osac-operator that referenced this pull request May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants