NO-ISSUE: Remove db-migrate Helm hook by jhernand · Pull Request #315 · osac-project/osac-installer

jhernand · 2026-06-23T14:25:46Z

Summary

Remove the db-migrate pre-upgrade Helm hook. The fulfillment service runs
database migrations automatically when it starts, so a separate Job is
unnecessary.
Clean up all related values, schema entries, CI workflow flags, and
documentation.

Test plan

Verify kustomize-build-all.sh passes.
Verify helm template renders without errors for all value files.
Confirm the fulfillment service starts and runs migrations on its own.

Summary by CodeRabbit

Refactor
- Removed database migration configuration and hooks from Helm deployment workflows, charts, and values files across all environments.
Documentation
- Simplified deployment guide by removing database migration hook references and troubleshooting sections.

The fulfillment service runs database migrations automatically when it starts, so a separate pre-upgrade Job is unnecessary. Remove the `db-migrate.yaml` hook template, the `dbMigrate` values and schema entries, all per-environment overrides, the `--set dbMigrate.enabled=false` flags from CI workflows, and the related documentation. Assisted-by: Cursor Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>

openshift-ci-robot · 2026-06-23T14:25:50Z

@jhernand: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Remove the db-migrate pre-upgrade Helm hook. The fulfillment service runs
database migrations automatically when it starts, so a separate Job is
unnecessary.

Clean up all related values, schema entries, CI workflow flags, and
documentation.

Test plan

Verify kustomize-build-all.sh passes.

Verify helm template renders without errors for all value files.

Confirm the fulfillment service starts and runs migrations on its own.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-23T14:25:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-06-23T14:26:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 36d14632-937e-4ade-8867-3fdb39257758

📥 Commits

Reviewing files that changed from the base of the PR and between 5c692e1 and 765c38e.

📒 Files selected for processing (10)

.github/workflows/helm-integration.yaml
charts/osac/ci/full-values.yaml
charts/osac/templates/hooks/db-migrate.yaml
charts/osac/values-example.yaml
charts/osac/values.schema.json
charts/osac/values.yaml
docs/helm-deployment-guide.md
values/caas-ci/values.yaml
values/development/values.yaml
values/vmaas-ci/values.yaml

💤 Files with no reviewable changes (10)

.github/workflows/helm-integration.yaml
values/vmaas-ci/values.yaml
charts/osac/templates/hooks/db-migrate.yaml
values/caas-ci/values.yaml
values/development/values.yaml
docs/helm-deployment-guide.md
charts/osac/values-example.yaml
charts/osac/values.yaml
charts/osac/values.schema.json
charts/osac/ci/full-values.yaml

Walkthrough

This PR removes the Helm dbMigrate configuration and related references from chart values, schema, examples, CI and environment values, workflow commands, the migration hook template, and deployment documentation.

Changes

Helm dbMigrate removal

Layer / File(s)	Summary
Chart values and hook removal `charts/osac/values.yaml`, `charts/osac/values.schema.json`, `charts/osac/values-example.yaml`, `charts/osac/ci/full-values.yaml`, `charts/osac/templates/hooks/db-migrate.yaml`, `values/.../values.yaml`	Removes the `dbMigrate` values/schema/examples, deletes the Helm migration hook template, drops environment-specific `dbMigrate` blocks, and adds a disabled `bmf` block in `values/vmaas-ci/values.yaml`.
Helm integration workflow updates `.github/workflows/helm-integration.yaml`	The integration workflow’s `helm install` and `helm upgrade` commands no longer pass `--set dbMigrate.enabled=false`.
Deployment guide cleanup `docs/helm-deployment-guide.md`	Removes the note about `dbMigrate.enabled` being disabled by default and deletes the troubleshooting section for migration hook failures.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

osac-project/osac-installer#98: Touches the same Helm integration workflow and umbrella chart areas where dbMigrate flags and hook behavior are changed here.
osac-project/osac-installer#229: Updates chart CI values that include dbMigrate, which connects directly to this PR’s removal of those values and schema entries.

Suggested reviewers

larsks
tzumainn
adriengentil

Poem

The migration hook packed up its gear,
And vanished from the chart this year.
Helm sails on with fewer lines,
Through values, docs, and CI signs.
A tidy diff, concise and bright ✨

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removal of the db-migrate Helm hook across all related files and configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	CI values files contain standard test placeholders (test-token, test-password) similar to development defaults; example files are templates. No hardcoded production credentials found in configuration.
No-Weak-Crypto	✅ Passed	PR removes db-migrate Helm hook (unrelated to cryptography). No weak crypto patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) introduced. Pre-existing md5sum for checksums and LegacyDES configura...
No-Injection-Vectors	✅ Passed	PR only removes db-migrate Helm hook configurations and documentation; no injection vectors are introduced in any added or modified code.
Container-Privileges	✅ Passed	This PR removes the db-migrate Helm hook and related configurations. Analysis confirms: (1) the deleted db-migrate.yaml contained no privileged containers, hostPID, hostNetwork, hostIPC, SYS_ADMIN...
No-Sensitive-Data-In-Logs	✅ Passed	PR removes sensitive database credentials from logs by eliminating db-migrate hook; no new logging of sensitive data introduced.
Ai-Attribution	✅ Passed	AI tool usage (Cursor) is properly attributed with Assisted-by trailer in commit message; no improper Co-Authored-By usage detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-06-23T15:37:42Z

@jhernand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vmaas	`765c38e`	link	true	`/test e2e-vmaas`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

omer-vishlitzky · 2026-06-23T16:39:36Z

ImagePullBackOff: Back-off pulling image "ghcr.io/osac-project/osac-operator:sha-db48159": ErrImagePull: pull QPS exceeded

/retest

openshift-ci · 2026-06-24T09:52:24Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

omer-vishlitzky · 2026-06-24T10:24:36Z

🏗️ CI Triage: infra | Category: BOOT

Root cause: The osac-operator pod failed to pull its image from ghcr.io due to a registry rate limit (pull QPS exceeded).

Explanation: During the boot step's refresh phase, the script waits for the OSAC deployments to roll out. The osac-operator deployment failed to start because its pod encountered an ImagePullBackOff error. The specific error from the container runtime was 'ErrImagePull: pull QPS exceeded', indicating that GitHub Container Registry (ghcr.io) rate-limited the image pull request. This is a transient infrastructure issue unrelated to the PR's code changes.

Evidence:

[e2e-vmaas-osac-project-cluster-tool-boot build-log.txt](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/osac-project_osac-installer/315/pull-ci-osac-project-osac-installer-main-e2e-vmaas/2069426706711580672/artifacts/e2e-vmaas/osac-project-gather/artifacts/osac-logs/e2e-vmaas-osac-project-cluster-tool-boot build-log.txt):

  wait fulfillment: osac-operator: osac-operator-f6658c6c9-h6dwg: ImagePullBackOff: Back-off pulling image "ghcr.io/osac-project/osac-operator:sha-db48159": ErrImagePull: pull QPS exceeded

Suggestion: Retrigger the job. If the issue persists, wait a while for the ghcr.io rate limit to reset before retesting.

Prow job | Build 2069426706711580672 | 🤖 triagent

_{For deeper investigation, use the /osac-debug-e2e skill with this build ID.}

omer-vishlitzky · 2026-06-25T05:10:47Z

/retest

openshift-ci-robot added the jira/valid-reference label Jun 23, 2026

openshift-ci Bot requested review from sk-ilya and tzumainn June 23, 2026 14:25

openshift-ci Bot added the approved label Jun 23, 2026

jhernand requested a review from eliorerz June 23, 2026 14:26

coderabbitai Bot approved these changes Jun 23, 2026

View reviewed changes

openshift-ci Bot added the needs-rebase label Jun 24, 2026

omer-vishlitzky closed this Aug 15, 2026

Navigation Menu

Uh oh!

NO-ISSUE: Remove db-migrate Helm hook - #315

NO-ISSUE: Remove db-migrate Helm hook#315
jhernand wants to merge 1 commit into
osac-project:mainfrom
jhernand:remove_db_migrate_helm_hook

jhernand commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Summary

Test plan

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

omer-vishlitzky commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

omer-vishlitzky commented Jun 24, 2026

Uh oh!

omer-vishlitzky commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jhernand commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Summary

Test plan

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

omer-vishlitzky commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

omer-vishlitzky commented Jun 24, 2026

Uh oh!

omer-vishlitzky commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jhernand commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading