Repository navigation
OSAC-496: Bump osac-aap for explicit tenant in publish_templates - #281
tchughesiv wants to merge 1 commit into
Conversation
Pick up osac-aap change that sets metadata.tenant=shared on template publish API payloads, required after fulfillment-service OSAC-496.
|
@tchughesiv: This pull request references OSAC-496 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchughesiv The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 59 minutes and 39 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — osac-installer has an automated submodule bump job; manual bump not needed. osac-aap publish_templates fix tracked in osac-aap PR 349. |
Summary
base/osac-aapsubmodule to include explicitmetadata.tenant=sharedon publish_templates API payloads (OSAC-496 follow-up)Why
After fulfillment-service PR 704, universal-access callers no longer get a server-side default tenant. The
osac-publish-templatesAAP job (template-publisher SA) must send explicitmetadata.tenant— fixed in osac-aap PR 349.Without this submodule bump, e2e-vmaas fails during template publish with
explicit tenant is required when subject has access to all tenants.Broader CLI/AAP tenancy design: OSAC-1546
Related PRs
Dependencies
Test plan