Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

OSAC-496: Bump osac-aap for explicit tenant in publish_templates - #281

Closed
tchughesiv wants to merge 1 commit into
osac-project:mainfrom
tchughesiv:OSAC-496-bump-osac-aap-publish-templates
Closed

tchughesiv wants to merge 1 commit into
osac-project:mainfrom
tchughesiv:OSAC-496-bump-osac-aap-publish-templates

Conversation

@tchughesiv

@tchughesiv tchughesiv commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Bumps base/osac-aap submodule to include explicit metadata.tenant=shared on publish_templates API payloads (OSAC-496 follow-up)

Why

After fulfillment-service PR 704, universal-access callers no longer get a server-side default tenant. The osac-publish-templates AAP job (template-publisher SA) must send explicit metadata.tenant — fixed in osac-aap PR 349.

Without this submodule bump, e2e-vmaas fails during template publish with explicit tenant is required when subject has access to all tenants.

Broader CLI/AAP tenancy design: OSAC-1546

Related PRs

Repo PR
fulfillment-service osac-project/fulfillment-service#704
osac-operator osac-project/osac-operator#297
osac-aap osac-project/osac-aap#349

Dependencies

Test plan

Pick up osac-aap change that sets metadata.tenant=shared on template
publish API payloads, required after fulfillment-service OSAC-496.
@openshift-ci-robot

openshift-ci-robot commented Jun 16, 2026 •

Copy link
Copy Markdown

@tchughesiv: This pull request references OSAC-496 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Bumps base/osac-aap submodule to include explicit metadata.tenant=shared on publish_templates API payloads (OSAC-496 follow-up)

Dependencies

Why

e2e-vmaas osac-publish-templates fails with explicit tenant is required when fulfillment-service OSAC-496 is deployed without this osac-aap fix.

Test plan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from adriengentil and tzumainn June 16, 2026 00:48
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchughesiv
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tchughesiv, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 39 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ba98f4a9-e72a-4217-8bf0-03b91b2980bc

📥 Commits

Reviewing files that changed from the base of the PR and between 8adc5ad and f9da834.

📒 Files selected for processing (1)
  • base/osac-aap
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tchughesiv

Copy link
Copy Markdown
Contributor Author

Closing — osac-installer has an automated submodule bump job; manual bump not needed. osac-aap publish_templates fix tracked in osac-aap PR 349.

@tchughesiv tchughesiv closed this Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants