OSAC-1534: Replace docker.io/envoyproxy/envoy with ghcr.io mirror - #277
Conversation
|
@eliorerz: This pull request references OSAC-1534 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 34 minutes and 6 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace all envoy image references from docker.io/envoyproxy/envoy to ghcr.io/osac-project/envoy to avoid Docker Hub rate limits and ImagePullBackOff on disconnected clusters. Add a GitHub Actions workflow to mirror the envoy image from Docker Hub to GHCR on demand and weekly.
548d07c to
21d3151
Compare
Summary
docker.io/envoyproxy/envoyimage references withghcr.io/osac-project/envoyto avoid Docker Hub rate limits andImagePullBackOffon disconnected clusters.github/workflows/mirror-envoy.yaml) to mirror the envoy image from Docker Hub to GHCR, triggered manually or on a weekly scheduleFiles changed
.github/workflows/mirror-envoy.yamlbase/kustomization.yamlnewNamecharts/osac/values.yamlcharts/osac/values-example.yamlvalues/development.yamlvalues/vmaas-ci.yamlvalues/caas-ci.yamlPre-requisites
Mirror Envoy Imageworkflow manually withv1.33.0to push the image to GHCR. Otherwise deployed clusters will getImagePullNotFound.ghcr.io/osac-project/envoypackage will be created as private by default. It must be changed to public in the osac-project org package settings after the first push, otherwise clusters without GHCR auth will still getImagePullBackOff.Test plan
v1.33.0and verifyghcr.io/osac-project/envoy:v1.33.0existsghcr.io/osac-project/envoypackage visibility to publichelm lint charts/osac/passeshelm templatewith all CI values files succeeds and showsghcr.io/osac-project/envoy:v1.33.0docker.io/envoyproxyreferences remain outside submodules and the mirror workflow SOURCEkustomize build base/produces nodocker.io/envoyproxyreferences