Bump osac-aap: OSAC-894 rename massopencloud collections to osac namespace - #170
Conversation
…space Update base/osac-aap submodule to merge commit from osac-project/osac-aap#309 and align installer overlays with the renamed collections: - osac.massopencloud removed from OSAC_TEMPLATE_COLLECTIONS (no longer in osac-aap) - massopencloud.steps renamed to osac.steps in overlay configuration - Sync CI overlay AAP image tags and git branch pins to sha-0255559 Original PR: osac-project/osac-aap#309 Merge commit: 025555900172e345a339e81ec0120c3fbe9f2db6
|
Warning Review limit reached
More reviews will be available in 53 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR updates container image tags and submodule pointers in the base kustomization, then standardizes Ansible collection references across documentation and all deployment overlays by replacing ChangesConfiguration Release Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Restore operator and fulfillment image tags to match submodule commits - Update vmaas-ci, caas-ci, and osac-integration AAP EE image and git branch pins
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@base/kustomization.yaml`:
- Line 30: Replace the short git-style tag currently set in newTag (e.g.,
"sha-682f856") with an immutable image digest or a full 40-char commit hash:
update the newTag entries to use image@sha256:<full-digest> where possible (or
at minimum sha-<40-char-commit>) and adjust any associated entries at the other
occurrences referenced in the comment; also update scripts/sync-image-tags.sh
(and any code that reads newTag) to support and propagate digest-format values
instead of short 7-char tags so the kustomization.yaml digest is used
end-to-end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: c7f94167-fce1-4d2d-8c97-a5d60648c898
📒 Files selected for processing (12)
base/kustomization.yamlbase/osac-aapdocs/aap-configuration.mddocs/helm-deployment-guide.mddocs/network-backend.mdoverlays/caas-ci/files/osac-aap-configuration.envoverlays/caas-ci/kustomization.yamloverlays/development/files/osac-aap-configuration.envoverlays/development/kustomization.yamloverlays/osac-integration/files/osac-aap-configuration.envoverlays/osac-integration/kustomization.yamloverlays/vmaas-ci/kustomization.yaml
|
/lgtm |
|
/lgtm |
|
@obochan-rh: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, obochan-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Summary
base/osac-aapsubmodule to pick up OSAC-894: rename massopencloud collections to osac namespace osac-aap#309sha-0255559massopencloud.steps→osac.stepsosac.massopencloudfromOSAC_TEMPLATE_COLLECTIONS(removed from osac-aap in OSAC-1693: expose ConfigMap inventory backend configuration in helm chart #309)Context
The auto bump workflow in osac-aap did not open this PR because the squash merge commit was not associated with PR #309 by the bot lookup.
Follow-up
MOC-specific templates previously in
osac.massopencloudwill need to be wired in viaosac-massopencloud-templatesas a separate dependency (tracked separately from OSAC-894).Test plan
scripts/sync-image-tags.shpasses on this branchkustomize build overlays/vmaas-ciOriginal PR: osac-project/osac-aap#309
Merge commit:
025555900172e345a339e81ec0120c3fbe9f2db6Made with Cursor
Summary by CodeRabbit
Chores
Configuration Updates