Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Bump osac-fulfillment-service: OSAC-832: Uniqueness Constraints and Validation of Public IP Attachm… - #156

Closed
osac-dev-bot wants to merge 1 commit into
mainfrom
bump/osac-fulfillment-service/pr-570
Closed

osac-dev-bot wants to merge 1 commit into
mainfrom
bump/osac-fulfillment-service/pr-570

Conversation

@osac-dev-bot

Copy link
Copy Markdown
Contributor

Bumps osac-fulfillment-service submodule.

Original PR: osac-project/fulfillment-service#570
Author: @DakCrowder
Merge commit: 1731e1dd2e2be55fb0463fd335c553d27c5f7960

@openshift-ci-robot

openshift-ci-robot commented May 21, 2026

Copy link
Copy Markdown

@osac-dev-bot: This pull request references OSAC-832 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Bumps osac-fulfillment-service submodule.

Original PR: osac-project/fulfillment-service#570
Author: @DakCrowder
Merge commit: 1731e1dd2e2be55fb0463fd335c553d27c5f7960

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from jhernand and trewest May 21, 2026 22:29
@openshift-ci

openshift-ci Bot commented May 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-dev-bot
Once this PR has been reviewed and has the lgtm label, please assign tzumainn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 790fa1a6-a7dc-49b2-93a5-4a123b4d7681

📥 Commits

Reviewing files that changed from the base of the PR and between c6de027 and 0c14309.

📒 Files selected for processing (2)
  • base/kustomization.yaml
  • base/osac-fulfillment-service

Summary by CodeRabbit

  • Chores
    • Updated fulfillment service to a new version.

Walkthrough

This PR updates the fulfillment-service version across the repository. The base/kustomization.yaml file updates the container image tag from sha-706c84a to sha-1731e1d, and the base/osac-fulfillment-service Git submodule reference is updated to the matching commit SHA. Both changes coordinate on the same new commit hash, ensuring the container image and submodule stay aligned.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the main change: bumping the osac-fulfillment-service submodule with a specific JIRA ticket (OSAC-832) related to uniqueness constraints and public IP validation.
Description check ✅ Passed The description directly relates to the changeset by explaining that the osac-fulfillment-service submodule is being bumped and provides relevant context including the original PR, author, and merge commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omer-vishlitzky

Copy link
Copy Markdown
Contributor

bumped here #163
/close

@openshift-ci openshift-ci Bot closed this May 25, 2026
@openshift-ci

openshift-ci Bot commented May 25, 2026

Copy link
Copy Markdown

@omer-vishlitzky: Closed this PR.

Details

In response to this:

bumped here #163
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants