Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Bump osac-fulfillment-service: OSAC-704: Add catalog_item support to Cluster and ComputeInstance create flow - #123

Closed
osac-dev-bot wants to merge 1 commit into
mainfrom
bump/osac-fulfillment-service/pr-549
Closed

osac-dev-bot wants to merge 1 commit into
mainfrom
bump/osac-fulfillment-service/pr-549

Conversation

@osac-dev-bot

Copy link
Copy Markdown
Contributor

Bumps osac-fulfillment-service submodule.

Original PR: osac-project/fulfillment-service#549
Author: @tzvatot
Merge commit: c70c64dd2095cc757b4c9a8a804d0670b16368fb

@openshift-ci-robot

openshift-ci-robot commented May 19, 2026 •

Copy link
Copy Markdown

@osac-dev-bot: This pull request references OSAC-704 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Bumps osac-fulfillment-service submodule.

Original PR: osac-project/fulfillment-service#549
Author: @tzvatot
Merge commit: c70c64dd2095cc757b4c9a8a804d0670b16368fb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented May 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-dev-bot
Once this PR has been reviewed and has the lgtm label, please ask for approval from tzvatot. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 93fb610e-4a45-4499-9b6a-25a6f2837449

📥 Commits

Reviewing files that changed from the base of the PR and between 7a84da0 and 2ca967b.

📒 Files selected for processing (1)
  • base/osac-fulfillment-service

Summary by CodeRabbit

  • Chores
    • Updated internal service dependencies to latest versions.

Walkthrough

This PR updates the tracked subproject commit for base/osac-fulfillment-service from 4fe43c145b167115c117f1d86d88142288170661 to c70c64dd2095cc757b4c9a8a804d0670b16368fb. The change advances the subproject reference to incorporate upstream changes from the fulfillment service repository.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: bumping the osac-fulfillment-service submodule with a reference to the upstream PR and its feature (catalog_item support for Cluster and ComputeInstance).
Description check ✅ Passed The description is directly related to the changeset, providing context about the submodule bump, upstream PR reference, author information, and merge commit hash.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tzvatot

tzvatot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Superseded by #125 which includes authconfig rego sync and correct image tag.

@tzvatot tzvatot closed this May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants