Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Fix the apiVersion for the HostedCluster resource - #14

Merged
larsks merged 1 commit into
osac-project:mainfrom
larsks:fix/hostedcluster-version
Apr 11, 2025
Merged

larsks merged 1 commit into
osac-project:mainfrom
larsks:fix/hostedcluster-version

Conversation

@larsks

@larsks larsks commented Apr 9, 2025

Copy link
Copy Markdown
Member

We were using v1alpha1 in the playbooks, but the current API version is v1beta1.

Summary by CodeRabbit

These updates ensure the platform remains aligned with the latest infrastructure standards, promoting improved long-term compatibility. While you may not notice any immediate changes to system behavior, this upgrade lays the groundwork for enhanced future performance.

  • Chores
    • Upgraded the cluster configuration to the latest supported API version.

We were using v1alpha1 in the playbooks, but the current API version is
v1beta1.
@larsks
larsks requested a review from adriengentil April 9, 2025 14:05
@coderabbitai

coderabbitai Bot commented Apr 9, 2025

Copy link
Copy Markdown

Walkthrough

The changes update the apiVersion field for the HostedCluster resource in the Kubernetes configuration. Specifically, the version is changed from hypershift.openshift.io/v1alpha1 to hypershift.openshift.io/v1beta1 in the roles/hosted_cluster/tasks/main.yml file. The update only affects the API version declaration while the other configurations, such as the resource kind, metadata, and spec, remain intact.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e40b00 and b9b5db0.

📒 Files selected for processing (1)
  • roles/hosted_cluster/tasks/main.yml (1 hunks)
🔇 Additional comments (1)
roles/hosted_cluster/tasks/main.yml (1)

35-35: Update API Version for HostedCluster Resource

The apiVersion field has been correctly updated to hypershift.openshift.io/v1beta1, which aligns with the latest API specifications and meets the PR objectives. Please verify that any consumers of the HostedCluster resource in your playbooks or other configurations are compatible with this new API version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants