NO-ISSUE: fix broken CI — replace removed Cores field in validation test

[alosadagrande]

Summary

• PR OSAC-1222: remove cores/memory_gib from ComputeInstance in favor of instance_type #866 removed cores/memory_gib from ComputeInstanceSpec in favor of instance_type
• PR OSAC-1416: enforce field_definitions as complete contract on catalog item usage #783 added a test referencing the now-removed Cores field
• Both merged close together, leaving CI broken on every PR rebased on current main
• Replaces Cores with InstanceType in the "rejects unlisted field on ComputeInstanceSpec" test

Test plan

• ginkgo run --focus="rejects unlisted field on ComputeInstanceSpec" internal/servers passes
• go build ./internal/servers/ compiles cleanly

Assisted-by: Claude Code noreply@anthropic.com

Summary by CodeRabbit

• Tests
  • Updated validation coverage to confirm that unlisted instance_type fields are correctly rejected for compute instance specifications.
  • Refined the expected invalid-argument error message for this validation scenario.

[openshift-ci-robot]

@alosadagrande: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• PR OSAC-1222: remove cores/memory_gib from ComputeInstance in favor of instance_type #866 removed cores/memory_gib from ComputeInstanceSpec in favor of instance_type
• PR OSAC-1416: enforce field_definitions as complete contract on catalog item usage #783 added a test referencing the now-removed Cores field
• Both merged close together, leaving CI broken on every PR rebased on current main
• Replaces Cores with InstanceType in the "rejects unlisted field on ComputeInstanceSpec" test

Test plan

• ginkgo run --focus="rejects unlisted field on ComputeInstanceSpec" internal/servers passes
• go build ./internal/servers/ compiles cleanly

Assisted-by: Claude Code noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: b6235f92-fcdc-4daa-95ee-fa13957ca8b9

📥 Commits

Reviewing files that changed from the base of the PR and between 9437c40 and 347e894.

📒 Files selected for processing (1)

• internal/servers/catalog_item_validation_test.go

---

Walkthrough

The unlisted-field rejection test now constructs ComputeInstanceSpec with InstanceType and expects the corresponding instance_type error message.

Changes

Validation test update

Layer / File(s)	Summary
Update unlisted-field validation coverage internal/servers/catalog_item_validation_test.go	The test uses ComputeInstanceSpec_builder with InstanceType and updates the expected invalid-argument message from cores to instance_type.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tzvatot

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating a validation test to replace the removed Cores field and fix CI.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	Diff only replaces ComputeInstanceSpec.Cores with InstanceType and updates the expected error text; no new secret-like literals or credentials were added.
No-Weak-Crypto	✅ Passed	Patch only updates a validation test from Cores to InstanceType; no weak crypto, custom crypto, or secret comparisons were added.
No-Injection-Vectors	✅ Passed	The only changed file is a Go test, and the diff only swaps test fixture fields/error text; no SQL, eval/exec, shell, pickle, YAML, or HTML injection sinks appear.
Container-Privileges	✅ Passed	PASS: The diff touches only a Go test file; no manifests or privilege flags (privileged, hostPID/network/IPC, SYS_ADMIN, allowPrivilegeEscalation) appear.
No-Sensitive-Data-In-Logs	✅ Passed	Only a test was changed; it contains no logging calls or emitted sensitive data, just field-name expectations.
Ai-Attribution	✅ Passed	AI use is attributed with an Assisted-by trailer in the commit; no Co-Authored-By AI attribution was found.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alosadagrande, mennyaboush
Once this PR has been reviewed and has the lgtm label, please assign rgolangh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alosadagrande]

PR #882 fixed the issue, closing.