OSAC-1905: Creating a ComputeInstance without runStrategy leaves it in "Reconciliation failed" with no indication to the user

[osac-jira-ai-issue-solver]

Resolves OSAC-1905

Summary

• Surface reconciliation errors in ComputeInstance status instead of only logging them
• When the fulfillment-service controller fails to create/update a K8s ComputeInstance CR (e.g., due to missing runStrategy), the instance status is now set to FAILED with the error message in the PROVISIONED condition
• Previously, reconciliation errors were only logged, leaving the instance stuck in STARTING with no user-visible indication of the problem

Test plan

• go build ./... compiles cleanly
• ginkgo run internal/controllers/computeinstance/ — 23/23 specs pass (3 new)
• ginkgo run internal/utils/ — 55/55 specs pass
• go vet — clean
• Deploy and verify: create a ComputeInstance without run_strategy, confirm status shows FAILED with error message instead of remaining stuck in STARTING

Fixes: OSAC-1905

[openshift-ci-robot]

@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-1905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Resolves OSAC-1905

Summary

• Surface reconciliation errors in ComputeInstance status instead of only logging them
• When the fulfillment-service controller fails to create/update a K8s ComputeInstance CR (e.g., due to missing runStrategy), the instance status is now set to FAILED with the error message in the PROVISIONED condition
• Previously, reconciliation errors were only logged, leaving the instance stuck in STARTING with no user-visible indication of the problem

Test plan

• go build ./... compiles cleanly
• ginkgo run internal/controllers/computeinstance/ — 23/23 specs pass (3 new)
• ginkgo run internal/utils/ — 55/55 specs pass
• go vet — clean
• Deploy and verify: create a ComputeInstance without run_strategy, confirm status shows FAILED with error message instead of remaining stuck in STARTING

Fixes: OSAC-1905

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[osac-jira-ai-issue-solver]

AI Session Costs

Session	Cost
New ticket	$6.25
Feedback (1) retry 3 (error)	$2.15
Feedback (1) retry 1 (no changes)	$0.96
Feedback (1) retry 2 (error)	$2.68
Feedback (1) retry 3 (unable)	$0.67
Merge conflict resolution	$2.28
Feedback (1)	$3.45
Feedback (2)	$2.14
Feedback (3) (no changes)	$2.60
Total	$23.18

[openshift-ci]

Hi @osac-jira-ai-issue-solver[bot]. Thanks for your PR.

I'm waiting for a osac-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eranco74]

PR needs rebase.

[osac-jira-ai-issue-solver]

In comment, @eranco74 said:

PR needs rebase.

I was unable to produce code changes to address this comment after multiple attempts.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: osac-jira-ai-issue-solver[bot]
Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[osac-jira-ai-issue-solver]

CI failures addressed in 931ef0f.

[osac-jira-ai-issue-solver]

CI failures addressed in 24100f6.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[eranco74]

Closing in favor of #903 which contains only the fix without the unrelated file deletions introduced during rebase.