Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

OSAC-1284: Implement ProjectMembership gRPC servers - #788

Merged
openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
CrystalChun:proj-mem-server
Jun 30, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
CrystalChun:proj-mem-server

Conversation

@CrystalChun

Copy link
Copy Markdown
Contributor

Description

Add public and private ProjectMembership servers following the standard server pattern. Public server wraps private server and adds tenant filtering. Both registered in gRPC server startup.

Add rendering table definitions for CLI display.

Testing

  • go unit test passes
  • go build passes

@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2026 •

Copy link
Copy Markdown

@CrystalChun: This pull request references OSAC-1284 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Description

Add public and private ProjectMembership servers following the standard server pattern. Public server wraps private server and adds tenant filtering. Both registered in gRPC server startup.

Add rendering table definitions for CLI display.

Testing

  • go unit test passes
  • go build passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@CrystalChun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: e9abcaf1-c4a3-4028-9c9c-dafe5bdc0df9

📥 Commits

Reviewing files that changed from the base of the PR and between e58d049 and a75c3be.

📒 Files selected for processing (6)
  • internal/cmd/service/start/grpcserver/start_grpc_server_cmd.go
  • internal/rendering/tables/osac.private.v1.ProjectMembership.yaml
  • internal/rendering/tables/osac.public.v1.ProjectMembership.yaml
  • internal/servers/generic_server.go
  • internal/servers/private_project_memberships_server.go
  • internal/servers/project_memberships_server.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CrystalChun
CrystalChun marked this pull request as draft June 26, 2026 14:28
@CrystalChun

Copy link
Copy Markdown
Contributor Author

requires #787

Add public and private ProjectMembership servers following the standard
server pattern. Public server wraps private server and adds tenant
filtering. Both registered in gRPC server startup.

Add rendering table definitions for CLI display.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@CrystalChun
CrystalChun marked this pull request as ready for review June 29, 2026 22:13
@openshift-ci
openshift-ci Bot requested a review from larsks June 29, 2026 22:13
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit dc1604f into osac-project:main Jun 30, 2026
14 checks passed
@CrystalChun
CrystalChun deleted the proj-mem-server branch July 10, 2026 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants