Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

NO-ISSUE: Add unit tests to validate table CEL expressions #770

Merged
openshift-merge-bot merged 2 commits into from
Jun 25, 2026
Merged

NO-ISSUE: Add unit tests to validate table CEL expressions #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5975776
NO-ISSUE: Extract interfaces for reflection `Helper` and `ObjectHelper`
jhernand Jun 24, 2026
1dc5eed
NO-ISSUE: Add unit test to validate CEL expressions in table definitions
jhernand Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cmd/cli/annotate/annotate_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type runnerContext struct {
logger *slog.Logger
console *terminal.Console
conn *grpc.ClientConn
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
}

func (c *runnerContext) run(cmd *cobra.Command, args []string) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/cli/delete/delete_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type runnerContext struct {
logger *slog.Logger
console *terminal.Console
conn *grpc.ClientConn
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
}

func (c *runnerContext) run(cmd *cobra.Command, args []string) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/cli/edit/edit_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ type runnerContext struct {
format string
conn *grpc.ClientConn
marshalOptions protojson.MarshalOptions
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
}

func (c *runnerContext) run(cmd *cobra.Command, args []string) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/cli/edit/edit_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var _ = Describe("Edit command", func() {
conn *grpc.ClientConn
console *terminal.Console
output *bytes.Buffer
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
)

BeforeEach(func() {
Expand Down
4 changes: 2 additions & 2 deletions internal/cmd/cli/get/get_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ type runnerContext struct {
console *terminal.Console
conn *grpc.ClientConn
marshalOptions protojson.MarshalOptions
globalHelper *reflection.Helper
objectHelper *reflection.ObjectHelper
globalHelper reflection.Helper
objectHelper reflection.ObjectHelper
}

func (c *runnerContext) run(cmd *cobra.Command, args []string) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/cli/get/get_cmd_watch_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var _ = Describe("Watch e2e", func() {
server *testing.Server
conn *grpc.ClientConn
eventsServer *testing.EventsServerFuncs
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
console *terminal.Console
)

Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/cli/label/label_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type runnerContext struct {
logger *slog.Logger
console *terminal.Console
conn *grpc.ClientConn
helper *reflection.ObjectHelper
helper reflection.ObjectHelper
}

func (c *runnerContext) run(cmd *cobra.Command, args []string) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/reflection/find_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type Renderer interface {
// Expected templates (looked up in the console's registered template set):
// - "no_matches.txt" vars: Object (string), Ref (string)
// - "multiple_matches.txt" vars: Matches ([]proto.Message), Object (string), Ref (string), Total (int32)
func (h *ObjectHelper) FindObject(ctx context.Context, ref string, console Renderer) (result proto.Message, err error) {
func (h *objectHelper) FindObject(ctx context.Context, ref string, console Renderer) (result proto.Message, err error) {
filter := fmt.Sprintf(`this.id == %[1]q || this.metadata.name == %[1]q`, ref)
response, err := h.List(ctx, ListOptions{
Filter: filter,
Expand Down
Loading