NO-ISSUE: Use new(expression) for remaining proto.Int32 calls - #617
Conversation
Continue the modernization started in 76d1516 by replacing the remaining `proto.Int32(value)` calls with the `new(int32(value))` built-in syntax introduced in Go 1.26. This also removes the now-unused `"google.golang.org/protobuf/proto"` imports from files where `proto.Int32` was the last usage of that package. Assisted-by: Cursor Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
|
@jhernand: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR removes a dependency on the ChangesProto Helper Removal and Native Pointer Allocation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, jhernand The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
12 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Summary
Continue the modernization started in #610 by replacing the remaining
proto.Int32(value)callswith the
new(int32(value))built-in syntax introduced in Go 1.26. This also removes thenow-unused
"google.golang.org/protobuf/proto"imports from files whereproto.Int32was the lastusage of that package.
Test plan
ginkgo run -r internal.Summary by CodeRabbit