This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Fix JSON encoding of Any - #60
Merged
Merged
Conversation
The protobuf `Any` type should be converted to the corresponding JSON
type, but our custom encoder doesn't do that, instead it converts its
fields. For example, an object created like this:
```go
object, err := anypb.New(wrapperspb.Bool(true))
```
Results in the following JSON:
```json
{
"type_url": "type.googleapis.com/google.protobuf.BoolValue"
"value": "CAE=",
}
```
But it should instead produce this:
```json
{
"@type": "type.googleapis.com/google.protobuf.BoolValue"
"value": true
}
```
This patch fixes that issue modifying our encoder so that it calls the
protobuf one for well known types like `Any` and `Timestamp`.
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
adriengentil
approved these changes
Jul 7, 2025
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protobuf
Anytype should be converted to the corresponding JSON type, but our custom encoder doesn't do that, instead it converts its fields. For example, an object created like this:Results in the following JSON:
{ "type_url": "type.googleapis.com/google.protobuf.BoolValue" "value": "CAE=", }But it should instead produce this:
{ "@type": "type.googleapis.com/google.protobuf.BoolValue" "value": true }This patch fixes that issue modifying our encoder so that it calls the protobuf one for well known types like
AnyandTimestamp.