NO-ISSUE: Move service Helm chart from `charts/service` to `chart` by jhernand · Pull Request #512 · osac-project/fulfillment-service

jhernand · 2026-05-08T19:17:23Z

Summary

Moves the service Helm chart from charts/service to a top-level chart directory,
giving the main chart a shorter, more conventional path for a single-chart repository.
Updates all references in the publish workflow, integration tests, unit tests, chart
README, authentication documentation, and pre-commit configuration.

Test plan

Unit tests pass (ginkgo run -r internal -- all 52 suites green).
Integration tests pass (CI).

Summary by CodeRabbit

Chores
- Reorganized chart directory structure and updated chart installation paths accordingly.
- Updated documentation, configuration, and deployment tools to reflect new chart layout.

openshift-ci-robot · 2026-05-08T19:17:26Z

@jhernand: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Moves the service Helm chart from charts/service to a top-level chart directory,
giving the main chart a shorter, more conventional path for a single-chart repository.

Updates all references in the publish workflow, integration tests, unit tests, chart
README, authentication documentation, and pre-commit configuration.

Test plan

Unit tests pass (ginkgo run -r internal -- all 52 suites green).

Integration tests pass (CI).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-08T19:26:19Z

Warning

Rate limit exceeded

@jhernand has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8598425f-cc85-4864-b048-7d0c196baf50

📥 Commits

Reviewing files that changed from the base of the PR and between a96cb95 and ebee590.

📒 Files selected for processing (30)

.github/workflows/publish-charts.yaml
.pre-commit-config.yaml
chart/Chart.yaml
chart/README.md
chart/templates/_helpers.tpl
chart/templates/admin/sa.yaml
chart/templates/authorino/authorino.yaml
chart/templates/authorino/certificate.yaml
chart/templates/client/sa.yaml
chart/templates/controller/certificate.yaml
chart/templates/controller/deployment.yaml
chart/templates/controller/sa.yaml
chart/templates/controller/service.yaml
chart/templates/grpc-server/authconfig.yaml
chart/templates/grpc-server/certificate.yaml
chart/templates/grpc-server/deployment.yaml
chart/templates/grpc-server/service.yaml
chart/templates/ingress-proxy/_config.yaml.tpl
chart/templates/ingress-proxy/certificate.yaml
chart/templates/ingress-proxy/configmap.yaml
chart/templates/ingress-proxy/deployment.yaml
chart/templates/ingress-proxy/service.yaml
chart/templates/rest-gateway/certificate.yaml
chart/templates/rest-gateway/deployment.yaml
chart/templates/rest-gateway/service.yaml
chart/templates/route.yaml
chart/values.yaml
docs/AUTH.md
internal/auth/auth_rules_test.go
it/it_tool.go

Walkthrough

This pull request consolidates the Helm chart directory structure from charts/service/ to chart/. The change affects the CI/CD publishing workflow, which now reads chart metadata from chart/Chart.yaml and updates chart/values.yaml before packaging. Documentation is updated to reflect new installation paths and template locations. Integration tests and deployment tooling are updated to reference the consolidated chart/ directory, and linting configuration is adjusted to exclude chart/templates from yamllint validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: moving the Helm chart directory from charts/service to chart, which aligns with the primary objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

The service chart was nested under `charts/service` alongside other supporting charts. Since it is the main chart of the repository it deserves a dedicated top-level `chart` directory, which also makes the path shorter and more conventional for single-chart repositories. All references have been updated accordingly in the publish workflow, integration test tooling, unit tests, chart README, and authentication documentation. The yamllint exclude pattern in the pre-commit configuration has also been adjusted to cover the new path. Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>

openshift-ci · 2026-05-17T16:43:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-19T11:09:42Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-18T21:33:57Z

@jhernand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	`ebee590`	link	true	`/test unit`
ci/prow/e2e-vmaas	`ebee590`	link	true	`/test e2e-vmaas`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference label May 8, 2026

openshift-ci Bot added the needs-rebase label May 16, 2026

jhernand force-pushed the move_service_helm_chart_to_chart_directory branch from a96cb95 to ebee590 Compare May 17, 2026 16:43

openshift-ci Bot added approved and removed needs-rebase labels May 17, 2026

jhernand closed this May 19, 2026

openshift-ci Bot added the needs-rebase label May 19, 2026

jhernand reopened this May 19, 2026

jhernand closed this Jun 25, 2026

Navigation Menu

Repository navigation

NO-ISSUE: Move service Helm chart from `charts/service` to `chart` - #512

NO-ISSUE: Move service Helm chart from `charts/service` to `chart`#512
jhernand wants to merge 1 commit into
osac-project:mainfrom
jhernand:move_service_helm_chart_to_chart_directory

jhernand commented May 8, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci-robot commented May 8, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented May 8, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

openshift-ci Bot commented May 17, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

openshift-ci Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jhernand commented May 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented May 8, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Estimated code review effort

Uh oh!

openshift-ci Bot commented May 17, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

openshift-ci Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jhernand commented May 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading