MGMT-23732/MGMT-23759: define PublicIPPool proto type and service

[akshaynadkarni]

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Summary by CodeRabbit

• New Features
  • Public IP Pool management: create, list (with pagination, filtering, ordering), retrieve, update, and delete pools.
  • Pools expose region, CIDR(s), IP family, lifecycle states, and capacity metrics (total, allocated, available).
  • Support for signaling reconciliation to trigger synchronization of an IP pool.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@akshaynadkarni: This pull request references MGMT-23759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaynadkarni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [akshaynadkarni]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@akshaynadkarni: This pull request references MGMT-23759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@akshaynadkarni: This pull request references MGMT-23759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Summary by CodeRabbit

Release Notes

• New Features
• Added Public IP Pool management functionality, enabling users to create, retrieve, update, and delete IP address pools.
• IP pools now track lifecycle states, capacity metrics (total, allocated, available), and maintain regional configuration settings.
• Added ability to signal reconciliation for IP pool synchronization.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Rate limit exceeded

@akshaynadkarni has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9888025c-9906-4690-8329-086255d38c17

📥 Commits

Reviewing files that changed from the base of the PR and between 0a07c5c and cda16f4.

⛔ Files ignored due to path filters (6)

• internal/api/osac/private/v1/public_ip_pool_type.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pool_type_protoopaque.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service.pb.gw.go is excluded by !**/*.pb.gw.go
• internal/api/osac/private/v1/public_ip_pools_service_grpc.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service_protoopaque.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (2)

• proto/private/osac/private/v1/public_ip_pool_type.proto
• proto/private/osac/private/v1/public_ip_pools_service.proto

Walkthrough

Adds two new protobuf files in package osac.private.v1: public_ip_pool_type.proto defining PublicIPPool, PublicIPPoolSpec (fields: cidrs, ip_family, implementation_strategy marked output-only/immutable), PublicIPPoolStatus (state, optional message, hub, total, allocated, available), and enums IPFamily and PublicIPPoolState; and public_ip_pools_service.proto defining the PublicIPPools gRPC service with messages and RPCs for List, Get, Create, Update (with FieldMask and lock), Delete, and Signal. REST HTTP bindings are declared for all RPCs except Signal.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

lgtm

Suggested reviewers

• adriengentil

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main changes: defining a new PublicIPPool proto type and service, with specific ticket references (MGMT-23732/MGMT-23759) for context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@proto/private/osac/private/v1/public_ip_pool_type.proto`:
- Around line 115-127: Fields total, allocated, and available in
public_ip_pool_type.proto use int32 and will overflow for IPv6-sized pools;
change their types to int64 (or sint64/uint64 if unsigned semantics are desired)
for the fields `total`, `allocated`, and `available` in the message defined in
public_ip_pool_type.proto (the three field names exactly) so they can represent
large IPv6 CIDR capacities, and then regenerate any protobuf stubs and update
any consumer code that assumes 32-bit values to use 64-bit integers.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 58de3620-ae2c-47aa-b0a5-198955b709de

📥 Commits

Reviewing files that changed from the base of the PR and between 6be00c4 and 8751d9f.

⛔ Files ignored due to path filters (6)

• internal/api/osac/private/v1/public_ip_pool_type.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pool_type_protoopaque.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service.pb.gw.go is excluded by !**/*.pb.gw.go
• internal/api/osac/private/v1/public_ip_pools_service_grpc.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pools_service_protoopaque.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (2)

• proto/private/osac/private/v1/public_ip_pool_type.proto
• proto/private/osac/private/v1/public_ip_pools_service.proto

[akshaynadkarni]

/hold

[eranco74]

Code Review: PublicIPPool Proto Definition

✅ Overall Assessment

Excellent proto design that follows established patterns. The implementation is clean, well-documented, and consistent with existing networking resources (VirtualNetwork, Subnet, SecurityGroup).

Strengths:

• Comprehensive proto documentation with clear state transition descriptions
• Proper immutability design (spec fields immutable after creation)
• Consistent state enum naming (PENDING maps from CRD Progressing phase)
• Good capacity tracking fields (total/allocated/available)
• All CI checks passing (buf lint, unit tests, integration tests)

---

🔴 Critical Issue: Integer Overflow Risk for IPv6 Pools

File: proto/private/osac/private/v1/public_ip_pool_type.proto
Lines: 115-127

Problem: The capacity fields use int32:

int32 total = 4;
int32 allocated = 5;
int32 available = 6;

Impact: A single IPv6 /64 CIDR contains 2^64 addresses (~18.4 quintillion), which exceeds int32 max value (2,147,483,647). This will cause integer overflow for any IPv6 pool.

Recommended Fix:

int64 total = 4;      // Changed from int32
int64 allocated = 5;  // Changed from int32
int64 available = 6;  // Changed from int32

Action Items:

1. Update the three capacity fields in PublicIPPoolStatus to int64
2. Run buf generate proto to regenerate Go code
3. Verify the generated .pb.go files use int64
4. Coordinate with osac-operator PR Add clearer error message when user attempts to access fulfillment-service with missing groups claim #176 to update CRD types to match

---

📝 Note on Proto Consistency

This issue also exists in the osac-operator CRD (api/v1alpha1/publicippool_types.go), which uses int32 for the same fields. Both should be updated together to maintain consistency between the proto schema and the Kubernetes CR.

---

Recommendation: Address the int64 change before merge, as it's a breaking schema change that's easier to fix now than after the BSR tag is published and consumed by osac-operator.

[openshift-ci-robot]

@akshaynadkarni: This pull request references MGMT-23759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Summary by CodeRabbit

Release Notes

• New Features
• Public IP Pool management: create, list, retrieve, update, and delete IP pools.
• Pools include region, CIDR(s), IP family, lifecycle states, and capacity metrics (total, allocated, available).
• Support for signaling reconciliation to trigger synchronization of an IP pool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

🧹 Nitpick comments (1)

proto/private/osac/private/v1/public_ip_pool_type.proto (1)

42-43: Add google.api.field_behavior = OUTPUT_ONLY annotation to the status field.

The status field is documented as read-only but lacks the explicit OUTPUT_ONLY annotation used elsewhere in this file (e.g., on implementation_strategy). This annotation clarifies the read-only contract for generated clients and aligns with Google Cloud API conventions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@proto/private/osac/private/v1/public_ip_pool_type.proto` around lines 42 -
43, The proto's status field is documented read-only but missing the explicit
annotation; update the status field declaration (the PublicIPPoolStatus status =
4 field) to include the google.api.field_behavior = OUTPUT_ONLY option—i.e., add
[(google.api.field_behavior) = OUTPUT_ONLY] to the field—making sure the
google/api/field_behavior.proto import is present (as used for
implementation_strategy) and that the field syntax and semicolon remain valid.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@proto/private/osac/private/v1/public_ip_pool_type.proto`:
- Around line 42-43: The proto's status field is documented read-only but
missing the explicit annotation; update the status field declaration (the
PublicIPPoolStatus status = 4 field) to include the google.api.field_behavior =
OUTPUT_ONLY option—i.e., add [(google.api.field_behavior) = OUTPUT_ONLY] to the
field—making sure the google/api/field_behavior.proto import is present (as used
for implementation_strategy) and that the field syntax and semicolon remain
valid.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9284d016-88b6-46d6-94b0-7a1922f2238e

📥 Commits

Reviewing files that changed from the base of the PR and between 8751d9f and 23d73ea.

⛔ Files ignored due to path filters (2)

• internal/api/osac/private/v1/public_ip_pool_type.pb.go is excluded by !**/*.pb.go
• internal/api/osac/private/v1/public_ip_pool_type_protoopaque.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (1)

• proto/private/osac/private/v1/public_ip_pool_type.proto

[akshaynadkarni]

Code Review: PublicIPPool Proto Definition

✅ Overall Assessment

Excellent proto design that follows established patterns. The implementation is clean, well-documented, and consistent with existing networking resources (VirtualNetwork, Subnet, SecurityGroup).

Strengths:

• Comprehensive proto documentation with clear state transition descriptions
• Proper immutability design (spec fields immutable after creation)
• Consistent state enum naming (PENDING maps from CRD Progressing phase)
• Good capacity tracking fields (total/allocated/available)
• All CI checks passing (buf lint, unit tests, integration tests)

🔴 Critical Issue: Integer Overflow Risk for IPv6 Pools

File: proto/private/osac/private/v1/public_ip_pool_type.proto Lines: 115-127

Problem: The capacity fields use int32:

int32 total = 4;
int32 allocated = 5;
int32 available = 6;

Impact: A single IPv6 /64 CIDR contains 2^64 addresses (~18.4 quintillion), which exceeds int32 max value (2,147,483,647). This will cause integer overflow for any IPv6 pool.

Recommended Fix:

int64 total = 4;      // Changed from int32
int64 allocated = 5;  // Changed from int32
int64 available = 6;  // Changed from int32

Action Items:

1. Update the three capacity fields in PublicIPPoolStatus to int64
2. Run buf generate proto to regenerate Go code
3. Verify the generated .pb.go files use int64
4. Coordinate with osac-operator PR Add clearer error message when user attempts to access fulfillment-service with missing groups claim #176 to update CRD types to match

📝 Note on Proto Consistency

This issue also exists in the osac-operator CRD (api/v1alpha1/publicippool_types.go), which uses int32 for the same fields. Both should be updated together to maintain consistency between the proto schema and the Kubernetes CR.

Recommendation: Address the int64 change before merge, as it's a breaking schema change that's easier to fix now than after the BSR tag is published and consumed by osac-operator.

@eranco74 I have updated the counters to use int64. PTAL.

[eranco74]

/lgtm

[akshaynadkarni]

/unhold

[akshaynadkarni]

/hold

[openshift-ci-robot]

@akshaynadkarni: This pull request references MGMT-23759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

MGMT-23759: Define the PublicIPPool proto type and gRPC service in the private API, the first subtask of MGMT-23732 (PublicIPPool Backend).

The type definition follows the CRD shape from osac-operator (single cidrs list + ip_family, not separate IPv4/IPv6 fields like Subnet). All spec fields are immutable after creation. The state enum uses PENDING (consistent with all other networking resources), and status includes capacity fields (total, allocated, available).

The service defines List, Get, Create, Update, Delete, and Signal RPCs with gRPC-gateway HTTP annotations on all except Signal.

Testing

Proto validation:

buf lint   # passed
buf generate   # 6 Go files generated (2 type + 4 service)
go build ./...   # passed
go run github.com/onsi/ginkgo/v2/ginkgo run -r --skip-package=it   # 33 suites, all passed

Container build and deploy to edge-22:

g-container-build -t fulfillment-service:mgmt-23732-proto .   # succeeded
podman push quay.io/rh-ee-anadkarn/fulfillment-service:mgmt-23732-proto   # succeeded
oc set image deployment/fulfillment-{controller,grpc-server,rest-gateway} ...   # all 3 rolled out
oc logs deployment/fulfillment-grpc-server -n osac-devel --since=2m   # clean startup, no errors
oc logs deployment/fulfillment-controller -n osac-devel --since=30s   # healthy after rollout settling

Pre-merge ToDos

1. After merge, CI pushes new BSR tag for buf.build/osac-project/private-api
2. Update osac-operator buf.gen.yaml to reference the new BSR tag, then buf mod update && buf generate (needed for MGMT-23733 Phase 5 feedback controller)

Related PRs

• osac-operator: MGMT-23733: add PublicIPPool CRD types and controller (Phases 1-4 done, Phase 5 blocked by this proto)

Ticket

MGMT-23759 (subtask of MGMT-23732, epic MGMT-23730)

Assisted-by: Cursor/Claude

Summary by CodeRabbit

• New Features
• Public IP Pool management: create, list (with pagination, filtering, ordering), retrieve, update, and delete pools.
• Pools expose region, CIDR(s), IP family, lifecycle states, and capacity metrics (total, allocated, available).
• Support for signaling reconciliation to trigger synchronization of an IP pool.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eranco74]

/lgtm

[akshaynadkarni]

/unhold