Rename user_data_secret_ref to user_data

[tzvatot]

Summary

• Rename user_data_secret_ref to user_data in public and private proto definitions
• Update reconciler to use HasUserData() / GetUserData()
• Rename CLI flag --user-data-secret-ref to --user-data
• The operator CRD field userDataSecretRef is unchanged — it correctly refers to a K8s Secret

The fulfillment API field accepts raw user data content (cloud-init, ignition, etc.), not a secret reference. The old name was misleading. user_data aligns with standard cloud provider terminology (AWS, OpenStack, GCP, KubeVirt).

Ref

https://redhat.atlassian.net/browse/MGMT-23397

Test plan

• Unit tests pass
• Integration tests

Generated with Claude Code

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[adriengentil]

why not user_data instead of cloud_init? It's a common name in cloud providers, and it matches the same name in ComputeInstance CR. Also we can pass ignition through the user data, it's not specific to cloud init.

[tzvatot]

why not user_data instead of cloud_init? It's a common name in cloud providers, and it matches the same name in ComputeInstance CR. Also we can pass ignition through the user data, it's not specific to cloud init.

My initial concern with user_data is that it's quite generic - in a broad sense every field the user provides is "user data".

That said, this is the established convention across cloud providers:

• AWS EC2: UserData
• OpenStack: user_data
• Azure: userData

So I'm on board — renamed to user_data. PTAL.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, tzvatot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [adriengentil,tzvatot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment