Skip to content
This repository was archived by the owner on Jun 9, 2026. It is now read-only.

Add explicit spec field flags to create computeinstance - #110

Merged
akshaynadkarni merged 1 commit into
osac-project:mainfrom
tzvatot:feature/ci-explicit-fields-mgmt-23103
Mar 3, 2026
Merged

akshaynadkarni merged 1 commit into
osac-project:mainfrom
tzvatot:feature/ci-explicit-fields-mgmt-23103

Conversation

@tzvatot

@tzvatot tzvatot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds CLI flags for the new ComputeInstance explicit spec fields, allowing users to specify compute instance configuration directly instead of only through template parameters.

New Flags

Flag Type Description
--cores int32 Number of CPU cores
--memory-gib int32 Memory size in GiB
--image string Image reference (e.g. OCI image URL)
--image-source-type string Image source type (default: "registry")
--ssh-key string SSH public key
--boot-disk-size int32 Boot disk size in GiB
--boot-disk-storage-class string Storage class for boot disk
--additional-disk string Additional disk (repeatable, kubectl-style key=value format)
--run-strategy string Run strategy (e.g. "Always" or "Halted")
--user-data-secret-ref string Name of the secret containing cloud-init user data

Example Usage

fulfillment-cli create computeinstance \
  --name my-instance \
  --template osac.templates.ocp_virt_vm \
  --cores 4 \
  --memory-gib 8 \
  --image quay.io/containerdisks/fedora:latest \
  --boot-disk-size 20 \
  --run-strategy Always \
  --additional-disk size=100,storageClass=fast \
  --additional-disk size=50

Related

Adds CLI flags for the new ComputeInstance explicit spec fields:
--cores, --memory-gib, --image, --image-source-type, --ssh-key,
--boot-disk-size, --boot-disk-storage-class, --additional-disk,
--run-strategy, --user-data-secret-ref.

Additional disks use kubectl-style key=value format:
  --additional-disk size=100,storageClass=fast

Also updates fulfillment-common to v0.0.40 for the new proto types.

https://issues.redhat.com/browse/MGMT-23103

Generated with [Claude Code](https://claude.com/claude-code)
@akshaynadkarni
akshaynadkarni force-pushed the feature/ci-explicit-fields-mgmt-23103 branch from 524a195 to 7d05d8a Compare March 3, 2026 03:06
@akshaynadkarni

Copy link
Copy Markdown
Contributor

/retest

@akshaynadkarni

Copy link
Copy Markdown
Contributor

/override ci/prow/temp

@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown

@akshaynadkarni: Overrode contexts on behalf of akshaynadkarni: ci/prow/temp

Details

In response to this:

/override ci/prow/temp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akshaynadkarni

Copy link
Copy Markdown
Contributor

/override ci/prow/images

@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown

@akshaynadkarni: Overrode contexts on behalf of akshaynadkarni: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akshaynadkarni
akshaynadkarni self-requested a review March 3, 2026 03:46

@akshaynadkarni akshaynadkarni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally.

@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaynadkarni, tzvatot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [akshaynadkarni,tzvatot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akshaynadkarni
akshaynadkarni merged commit f99fe01 into osac-project:main Mar 3, 2026
7 checks passed
@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown

@tzvatot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 7d05d8a link unknown /test images
ci/prow/temp 7d05d8a link unknown /test temp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants