Add explicit spec field flags to create computeinstance - #110
akshaynadkarni merged 1 commit into
Conversation
Adds CLI flags for the new ComputeInstance explicit spec fields: --cores, --memory-gib, --image, --image-source-type, --ssh-key, --boot-disk-size, --boot-disk-storage-class, --additional-disk, --run-strategy, --user-data-secret-ref. Additional disks use kubectl-style key=value format: --additional-disk size=100,storageClass=fast Also updates fulfillment-common to v0.0.40 for the new proto types. https://issues.redhat.com/browse/MGMT-23103 Generated with [Claude Code](https://claude.com/claude-code)
524a195 to
7d05d8a
Compare
|
/retest |
|
/override ci/prow/temp |
|
@akshaynadkarni: Overrode contexts on behalf of akshaynadkarni: ci/prow/temp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/images |
|
@akshaynadkarni: Overrode contexts on behalf of akshaynadkarni: ci/prow/images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
akshaynadkarni
left a comment
There was a problem hiding this comment.
Tested the changes locally.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akshaynadkarni, tzvatot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tzvatot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Adds CLI flags for the new ComputeInstance explicit spec fields, allowing users to specify compute instance configuration directly instead of only through template parameters.
New Flags
--cores--memory-gib--image--image-source-type--ssh-key--boot-disk-size--boot-disk-storage-class--additional-disk--run-strategy--user-data-secret-refExample Usage
Related