Skip to content

OSAC-1110: storage UI design doc follow-ups (post-#183) - #187

Merged
openshift-merge-bot[bot] merged 2 commits into
osac-project:mainfrom
ElayAharoni:docs/OSAC-1110-storage-ui-followups
Aug 5, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
osac-project:mainfrom
ElayAharoni:docs/OSAC-1110-storage-ui-followups

Conversation

@ElayAharoni

@ElayAharoni ElayAharoni commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two small follow-ups to the storage UI design doc that were pushed to design/OSAC-1110-storage-tier-ui after PR #183 had already merged, so they never landed in main:

  • Tighten Motivation: it had accumulated changelog-style narration across several revision rounds ("an earlier revision of this document used...", "confirmed on the 2026-08-04 storage-scope call") — useful mid-review, but redundant with 08-review-responses.md, which already tracks that history. Rewritten to state the current reasoning directly.
  • Cite the OSAC-1111 PRD: the frontmatter and Summary only referenced OSAC-1110's own PRD, even though this design implements OSAC-1111 (StorageBackend) requirements directly — full CRUD, not just a read-only picker. Both PRDs are now cited.

Test plan

  • Docs-only change to enhancements/OSAC-1110-storage-tier/ui-design.md — no code affected

Summary by CodeRabbit

  • Documentation
    • Updated storage tier design documentation to align with the backend requirements and design.
    • Clarified administrative workflows for creating, viewing, updating, and deleting storage backends and storage tiers.
    • Defined Cloud Provider Admin-only access and documented that backend details remain hidden from tenant-facing experiences.
    • Added workflow revision metadata for improved design traceability.

Motivation had accumulated changelog-style narration across several
revision rounds ("an earlier revision of this document used...",
"confirmed on the 2026-08-04 storage-scope call") -- useful mid-review
but redundant with 08-review-responses.md, which already tracks that
history. Rewritten to state the current reasoning directly: why full
CRUD for both resources, why this phase is CSP-admin-only, and why
tenants must stay unaware of StorageBackend.
This design implements OSAC-1111 (StorageBackend) requirements
directly -- full CRUD, not just a read-only picker -- so both PRDs
belong in the frontmatter and Summary, not just OSAC-1110's own.
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026 •

Copy link
Copy Markdown

@ElayAharoni: This pull request references OSAC-1110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Two small follow-ups to the storage UI design doc that were pushed to design/OSAC-1110-storage-tier-ui after PR #183 had already merged, so they never landed in main:

  • Tighten Motivation: it had accumulated changelog-style narration across several revision rounds ("an earlier revision of this document used...", "confirmed on the 2026-08-04 storage-scope call") — useful mid-review, but redundant with 08-review-responses.md, which already tracks that history. Rewritten to state the current reasoning directly.
  • Cite the OSAC-1111 PRD: the frontmatter and Summary only referenced OSAC-1110's own PRD, even though this design implements OSAC-1111 (StorageBackend) requirements directly — full CRUD, not just a read-only picker. Both PRDs are now cited.

Test plan

  • Docs-only change to enhancements/OSAC-1110-storage-tier/ui-design.md — no code affected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from danmanor and mhrivnak August 5, 2026 06:08
@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 50956d0e-75e7-47da-a567-5216acf26a52

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6ec7a and 34c1bae.

📒 Files selected for processing (1)
  • enhancements/OSAC-1110-storage-tier/ui-design.md

Walkthrough

The storage tier UI design now references OSAC-1111, covers admin CRUD for StorageBackend and StorageTier, defines Cloud Provider Admin scope, limits tenant-facing data to tier fields, and records an additional workflow revision phase.

Changes

Storage tier UI design

Layer / File(s) Summary
Admin CRUD scope and design references
enhancements/OSAC-1110-storage-tier/ui-design.md
The design references the OSAC-1111 backend PRD and both resource designs. It defines full admin CRUD for StorageBackend and StorageTier, clarifies Cloud Provider Admin scope, and excludes backend details from future tenant-facing APIs. The workflow provenance metadata includes an additional revision phase.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: akshaynadkarni

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning The PR diff updates an explicit ai-workflow-provenance marker, but both PR commits have no parsed trailers; required Assisted-by/Generated-by attribution is missing. Amend each AI-assisted PR commit with an Assisted-by or Generated-by trailer naming the tool; do not use Co-Authored-By for AI.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the OSAC-1110 storage UI design document follow-up changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The PR changes one Markdown file. Added lines contain only documentation links, prose, and provenance metadata; scans found no secret assignments, credential URLs, private keys, vendor key shapes,...
No-Weak-Crypto ✅ Passed The PR changes only one Markdown document; its diff contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison logic.
No-Injection-Vectors ✅ Passed The PR changes only one Markdown design document. The added lines contain links, prose, and metadata; scans found no SQL concatenation, shell, eval/exec, pickle, unsafe YAML, os.system, or innerHTM...
Container-Privileges ✅ Passed The PR changes only one Markdown design document. The patch adds PRD links and provenance text, with no container or Kubernetes manifest and no privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only one Markdown design file; added lines contain no logging constructs or sensitive values, and existing logging notes mention only resource IDs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ElayAharoni
ElayAharoni requested review from akshaynadkarni and removed request for danmanor and mhrivnak August 5, 2026 06:32

@akshaynadkarni akshaynadkarni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaynadkarni, ElayAharoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Aug 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit e49bc0c into osac-project:main Aug 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants