NO-ISSUE: skip EP review for forgeSmith-bot PRs

[ItzikEzra-rh]

Summary

• Skip automatic EP review when PR author is forgeSmith-bot
• Forge pushes commits in response to review feedback, re-triggering the workflow via synchronize events, creating an infinite loop (see PR [OSAC-3254] PRD: Expose Inventory Metadata in BareMetalInstance Status #169)
• Manual /review-ep comments still work on Forge PRs

Test plan

• Verify existing Forge PRs no longer trigger ep-review on push
• Verify /review-ep comment on a Forge PR still triggers review
• Verify non-Forge PRs still get automatic review

Summary by CodeRabbit

• Bug Fixes
  • Prevented the automated pull request review workflow from running for pull requests created by the forgeSmith-bot account.

[coderabbitai]

Walkthrough

The resolve-pr job in the pull request review workflow now skips pull_request_target events when the pull request author is forgeSmith-bot.

Changes

Review workflow filtering

Layer / File(s)	Summary
Restrict resolve-pr execution .github/workflows/ep-review.yml	The job condition now requires the pull request author login to differ from forgeSmith-bot for pull_request_target events.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	Changed only a workflow condition; no hardcoded secret/token/password literals, embedded creds, or long base64 blobs were introduced.
No-Weak-Crypto	✅ Passed	Only a workflow guard changed; no MD5/SHA1/DES/RC4/ECB/custom crypto or secret-comparison code was added.
No-Injection-Vectors	✅ Passed	Only a GitHub Actions if-condition changed; no SQL, shell, eval/exec, pickle, yaml.load, os.system, or unsafe HTML patterns were introduced.
Container-Privileges	✅ Passed	Only a workflow file changed; no container/K8s manifests or privilege settings (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation) were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only tightens a workflow condition; it adds no new logging or debug output that would expose secrets or PII.
Ai-Attribution	✅ Passed	The PR commit mentions Claude Code and includes a proper Assisted-by trailer; no Co-Authored-By AI attribution was found.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: skipping EP review for forgeSmith-bot pull requests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@ItzikEzra-rh: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Skip automatic EP review when PR author is forgeSmith-bot
• Forge pushes commits in response to review feedback, re-triggering the workflow via synchronize events, creating an infinite loop (see PR [OSAC-3254] PRD: Expose Inventory Metadata in BareMetalInstance Status #169)
• Manual /review-ep comments still work on Forge PRs

Test plan

• Verify existing Forge PRs no longer trigger ep-review on push
• Verify /review-ep comment on a Forge PR still triggers review
• Verify non-Forge PRs still get automatic review

Summary by CodeRabbit

• Bug Fixes
• Prevented the automated pull request review workflow from running for pull requests created by the forgeSmith-bot account.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eranco74]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, ItzikEzra-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eranco74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eranco74]

/hold

[eranco74]

We do want the review, this seems like a better fix
forge-sdlc/forge#232