OSAC-3153: fix detect_skills matching ui-design.md as design.md

[ItzikEzra-rh]

Summary

• detect_skills() used endswith("design.md") which incorrectly matched ui-design.md and ux-design.md
• Switch to os.path.basename() exact match so only files named exactly design.md or prd.md trigger reviews

Root cause

"ui-design.md".endswith("design.md") is True in Python — the suffix check is too broad.

Observed on PR #123 (Organizations & Authentication UI design).

Test plan

• Verified locally: detect_skills(["enhancements/organizations/ui-design.md"]) returns []
• Verified locally: detect_skills(["enhancements/organizations/design.md"]) returns ["design-review"]
• All edge cases pass (ux-design, prd, readme, both files, unrelated)
• CI passes

Fixes: OSAC-3153

[openshift-ci-robot]

@ItzikEzra-rh: This pull request references OSAC-3153 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• detect_skills() used endswith("design.md") which incorrectly matched ui-design.md and ux-design.md
• Switch to os.path.basename() exact match so only files named exactly design.md or prd.md trigger reviews

Root cause

"ui-design.md".endswith("design.md") is True in Python — the suffix check is too broad.

Observed on PR #123 (Organizations & Authentication UI design).

Test plan

• Verified locally: detect_skills(["enhancements/organizations/ui-design.md"]) returns []
• Verified locally: detect_skills(["enhancements/organizations/design.md"]) returns ["design-review"]
• All edge cases pass (ux-design, prd, readme, both files, unrelated)
• CI passes

Fixes: OSAC-3153

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Review limit reached

@ItzikEzra-rh, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c3c083c1-6925-4b12-8ffb-1b6f07b5cb53

📥 Commits

Reviewing files that changed from the base of the PR and between 4e8ad80 and f782285.

📒 Files selected for processing (1)

• .github/scripts/ep_review.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, ItzikEzra-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment