OSAC-3548: Fix IsRestartComplete to wait for host to power on

internal/management/metal3.go

@@ -202,9 +202,12 @@ func (m *Metal3Client) IsRestartComplete(ctx context.Context, hostID string) (bo
 		return false, err
 	}
 
-	// Restart is complete when the reboot annotation is no longer present
+	// Restart is complete when the reboot annotation has been processed and
+	// the host is back online. Checking only the annotation is insufficient
+	// because the BMH controller removes it as soon as the reboot command is
+	// sent to Ironic, before the host finishes rebooting.
 	_, hasRebootAnnotation := bmh.Annotations[metal3api.RebootAnnotationPrefix]
-	return !hasRebootAnnotation, nil
+	return !hasRebootAnnotation && bmh.Status.PoweredOn, nil
 }
 
 func (m *Metal3Client) getBMH(ctx context.Context, hostID string) (*metal3api.BareMetalHost, error) {

internal/management/metal3_test.go

@@ -260,6 +260,15 @@ var _ = Describe("Metal3 Management Backend", func() {
 			Expect(complete).To(BeTrue())
 		})
 
+		It("returns false when annotation is gone but host is not powered on", func() {
+			bmh := newBMHForManagement("host-rebooting", true, false)
+			m := newMetal3ManagementClient(bmh)
+
+			complete, err := m.IsRestartComplete(ctx, metal3TestNamespace+"/host-rebooting")
+			Expect(err).NotTo(HaveOccurred())
+			Expect(complete).To(BeFalse())
+		})
+
 		It("returns false when reboot annotation is present", func() {
 			annotations := map[string]string{
 				metal3api.RebootAnnotationPrefix: "",