Skip to content

containers/bats: Load null_blk module for podman tests#21929

Merged
ricardobranco777 merged 1 commit intoos-autoinst:masterfrom
ricardobranco777:nullb0
Apr 30, 2025
Merged

containers/bats: Load null_blk module for podman tests#21929
ricardobranco777 merged 1 commit intoos-autoinst:masterfrom
ricardobranco777:nullb0

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Apr 30, 2025

Load null_blk module for podman tests.

Since /dev/zero is not a block device, it's unsuitable for testing cgroup controls designed for block devices.

From containers/podman#26022 (comment)

asmorodskyi
asmorodskyi approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe VR ?

@ricardobranco777
Copy link
Contributor Author

ricardobranco777 commented Apr 30, 2025 •
edited
Loading

LGTM but maybe VR ?

Not really needed because of || true, and we'll see the benefits with a version of podman that includes the linked PR.

@ricardobranco777 ricardobranco777 merged commit b429ba3 into os-autoinst:master Apr 30, 2025
11 checks passed
@ricardobranco777 ricardobranco777 deleted the nullb0 branch April 30, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorodskyi asmorodskyi asmorodskyi approved these changes

@pdostal pdostal Awaiting requested review from pdostal pdostal is a code owner

@grisu48 grisu48 Awaiting requested review from grisu48 grisu48 is a code owner

@mloviska mloviska Awaiting requested review from mloviska mloviska is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ricardobranco777 @asmorodskyi