feat: allow Go migrations outside of an SQL transaction #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
requested changes
Jun 17, 2023
aeneasr
approved these changes
Jun 26, 2023
hperl
requested changes
Jun 26, 2023
| if _, err := c.Store.Exec("INSERT INTO tests (i, j) VALUES (?, ?)", i1, j1); err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
| close(up1) |
There was a problem hiding this comment.
This took me a while to understand. You are passing control back here to see if the changes take effect immediately, right? Could you not just execute a closure instead which connection is bound to the top-level c?
Define in the top level:
assertValues := func(i int) {
var j int64
require.NoError(t, c.Store.Get(&j, "SELECT j FROM tests WHERE i = ?", i))
assert.Equal(t, j1, j)And then call it as part of the migrations.
There was a problem hiding this comment.
From my side it's ok to merge as is
There was a problem hiding this comment.
Yeah, the closure would work too. Would be a little bit neater perhaps.
This works, so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.