Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): update reqwest to 0.12 #356

Closed
wants to merge 1 commit into from

Conversation

baszalmstra
Copy link

This patchs bumps the reqwest version used by the Rust SDK from 0.11 to 0.12. It basically takes the commit from #345 . I do not know why that was deleted..

Related Issue or Design Document

Reqwest 0.12 has been out for 2 months. It would be nice to share the same reqwest Client with multiple crates but a lot of crates update to reqwest 0.12. This makes the reqwest Client incompatible with the version used in the Ory SDK.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The touched files are autogenerated and can unfortunately not be upgraded that way. Your changes need to land in openapi-generator first. Thank you for your contribution in any case!

@jobs62
Copy link

jobs62 commented Jun 7, 2024

@aeneasr aeneasr closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants