Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delegate authenticator #1153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yunier-rojas
Copy link

@yunier-rojas yunier-rojas commented Mar 2, 2024

Problem Summary

This merge request addresses issue #669 surrounding the behavior of the "noop" authentication method, which underwent changes in commit 6f8ab4f. Reverting these changes to restore the previous behavior is challenging due to the potential for breaking existing systems. To mitigate this risk, we propose implementing a new authenticator named "delegate" to replicate the original behavior of the "noop" method.

Ideal Solution

To address this issue, our proposed solution is to implement a new authenticator named "delegate" that replicates the original behavior of the "noop" method. This approach ensures that existing systems in production remain stable and unaffected by changes, while also providing users who prefer the old behavior with an option to utilize it. By introducing the "delegate" authenticator, we mitigate the risk of breaking changes while offering flexibility to users who require the previous behavior.

Changes Proposed

  1. New Authenticator Module: This MR adds a new authenticator module named "delegate" to replicate the original behavior of the "noop" method.

  2. Integration Tests: Integration tests will be added to validate the functionality of the "delegate" authenticator, ensuring compatibility and reliability.

  3. Documentation Updates: Documentation will be updated to include details about the new "delegate" authenticator, its configuration options, and usage examples.

Related Issues

#1152
#669

closes 1152

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

## Problem Summary

This merge request addresses issue !669 surrounding the behavior
of the "noop" authentication method, which underwent changes in commit
6f8ab4f. Reverting these changes to restore the previous behavior is
challenging due to the potential for breaking existing systems. To mitigate
this risk, we propose implementing a new authenticator named "delegate" to
replicate the original behavior of the "noop" method.

## Ideal Solution

To address this issue, our proposed solution is to implement a new
authenticator named "delegate" that replicates the original behavior of the
"noop" method. This approach ensures that existing systems in production
remain stable and unaffected by changes, while also providing users who
prefer the old behavior with an option to utilize it. By introducing the
"delegate" authenticator, we mitigate the risk of breaking changes while
offering flexibility to users who require the previous behavior.

## Changes Proposed

1. **New Authenticator Module**: This MR adds a new authenticator module
named "delegate" to replicate the original behavior of the "noop" method.

3. **Integration Tests**: Integration tests will be added to validate the
functionality of the "delegate" authenticator, ensuring compatibility and
reliability.

4. **Documentation Updates**: Documentation will be updated to include
details about the new "delegate" authenticator, its configuration options,
and usage examples.

## Related Issues

ory#1152
ory#669

closes 1152
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (8fc9b7a) to head (2bbd810).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
+ Coverage   77.90%   77.98%   +0.07%     
==========================================
  Files          80       81       +1     
  Lines        3929     3942      +13     
==========================================
+ Hits         3061     3074      +13     
  Misses        595      595              
  Partials      273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yunier-rojas added a commit to yunier-rojas/ory-docs that referenced this pull request Mar 7, 2024
ory/oathkeeper#1153 implements
a new authenticator to allow authn/authz delegation
to upstream services.
yunier-rojas added a commit to yunier-rojas/ory-docs that referenced this pull request Mar 7, 2024
ory/oathkeeper#1153 implements
a new authenticator to allow authn/authz delegation
to upstream services.

Relates to ory/oathkeeper#1152
yunier-rojas added a commit to yunier-rojas/ory-docs that referenced this pull request Mar 7, 2024
ory/oathkeeper#1153 implements
a new authenticator to allow authn/authz delegation
to upstream services.

Relates to ory/oathkeeper#1152
yunier-rojas added a commit to yunier-rojas/ory-docs that referenced this pull request Mar 7, 2024
ory/oathkeeper#1153 implements
a new authenticator to allow authn/authz delegation
to upstream services.

Relates to ory/oathkeeper#1152
yunier-rojas added a commit to yunier-rojas/ory-docs that referenced this pull request Mar 7, 2024
ory/oathkeeper#1153 implements
a new authenticator to allow authn/authz delegation
to upstream services.

Relates to ory/oathkeeper#1152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant