fix: do not roll back transaction on partial identity insert error #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Nov 14, 2024
| @@ -637,7 +639,7 @@ func (p *IdentityPersister) CreateIdentities(ctx context.Context, identities ... | |||
| return sqlcon.HandleError(err) | |||
| } | |||
|
|
|||
| return partialErr | |||
There was a problem hiding this comment.
I agree that rolling back the transaction is unwanted, but we do want to return information about which identity inserts failed. Don't we lose that information here?
There was a problem hiding this comment.
Ah sorry, I misread, looks good!
hperl
requested changes
Nov 14, 2024
| @@ -637,7 +639,7 @@ func (p *IdentityPersister) CreateIdentities(ctx context.Context, identities ... | |||
| return sqlcon.HandleError(err) | |||
| } | |||
|
|
|||
| return partialErr | |||
There was a problem hiding this comment.
I agree that rolling back the transaction is unwanted, but we do want to return information about which identity inserts failed. Don't we lose that information here?
hperl
approved these changes
Nov 14, 2024
…insert-persists-on-failure
…insert-persists-on-failure
zepatrik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on #4083, where the basic feature was implemented but the transaction was eventually rolled back also it seemed like it succeeded.